Don't crash when there's no design doc - #118
Merged
Merged
Conversation
naftali-g
force-pushed
the
naftali/auto-create-design-doc
branch
from
August 5, 2026 06:09
b2b01c9 to
7120bc4
Compare
jtoman
approved these changes
Aug 5, 2026
jtoman
left a comment
jtoman
left a comment
Contributor
There was a problem hiding this comment.
seems to do what it says on the tin
| embed_model=model, | ||
| root_key=root_key, | ||
| source=SourceCode( | ||
| content=system_doc_doc, |
ericeil
added a commit
that referenced
this pull request
Aug 5, 2026
Two overlaps needed resolving beyond the textual merge. `pyproject.toml` package-data: master widened `templates/*.j2` to `templates/**/*.j2` to ship the template subdirectories; this branch had independently added both that glob and `templates/*.js`. setuptools globs package-data with `recursive=True`, so `**` already matches the top-level files and the separate `templates/*.j2` entry was redundant — kept master's glob plus the `.js` entry this branch needs for `prism-cvl.js`. The design doc became optional on master (#118): `resolve_design_doc` returns `None` instead of raising, `SourceCode.content` is nullable, and `SourceCode` no longer derives from `SystemDoc`. The Rust entry point resolves its own design doc, so it had the same fail-fast assumption and its own copy of the root cache key. It now degrades to a source-only run the same way, and `_root_cache_key` delegates to `pipeline.cli.root_cache_key` so the no-doc sentinel is defined once rather than in two places; the Rust side keeps only its truncation. Nothing on the Rust, Solana, Foundry or pipeline paths dereferences the doc content, so component analysis remains its sole consumer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.