Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

Fix the to_one relationship and enhance the testing - #613

Merged
grieve54706 merged 8 commits into
Canner:mainfrom
goldmedal:bugfix/fix-to-one-relation-refactor-chain
Jun 20, 2024
Merged

grieve54706 merged 8 commits into
Canner:mainfrom
goldmedal:bugfix/fix-to-one-relation-refactor-chain

Conversation

@goldmedal

Copy link
Copy Markdown
Contributor

Changed

  • The to_one relationship is available now.
  • Ensure the generated plan is executable for DataFusion.
    • If table providers are registered, generate the DefaultTableSource for remote table sources.
    • If no, generate the LogicalTableSource for remote table sources. (It can't be executed by DataFusion)
  • Enhance the end to end testing

{
"name": "customer",
"tableReference": "main.customer",
"tableReference": "customer",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the schema?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing context, RemoteContextProvider, only register the table name without the schema. In this case, the table reference shouldn't have schema prefix.

@grieve54706
grieve54706 merged commit 95e768f into Canner:main Jun 20, 2024
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
* finish the to_one relationship query

* modified and enhance the tests

* cargo clippy

* add examples for some use cases

* fix cargo typo

* modified the example

* fix the example

* fix typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants