Skip to content

Remove duplicate mllist mapPartial definition - #1478

Open
mah1104ahm wants to merge 1 commit into
CakeML:masterfrom
mah1104ahm:codex/remove-mllist-map-partial
Open

mah1104ahm wants to merge 1 commit into
CakeML:masterfrom
mah1104ahm:codex/remove-mllist-map-partial

Conversation

@mah1104ahm

Copy link
Copy Markdown

Summary

  • remove the duplicate mapPartial definition from mllist
  • prove the existing mapPartial_thm against listTheory.mapPartial_def
  • leave the public theorem available to downstream scripts

Verification

  • confirmed basis/pure/mllistScript.sml no longer defines mapPartial
  • git diff --check
  • full HOL build not run locally because Holmake is unavailable

Closes #1449

@tanyongkiam

Copy link
Copy Markdown
Contributor

Hi, thanks for the contribution.

I think the PR should be done more carefully and with HOL used (at least checking the files that were touched).

For example, there still remains references to mllistTheory.mapPartial_def.

@tanyongkiam tanyongkiam added the test failing regression test failed on the latest commit of this pull request label Sep 2, 2026
@mah1104ahm

mah1104ahm commented Sep 3, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test failing regression test failed on the latest commit of this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mapPartial from mllist

2 participants