Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tested next/previous, pause/resume, automatic cycling and same-tab fullscreen on my test setup. My local DOM regression checks cover countdown/progress, translated labels, repeated initialization, one/no-map cases, clicks/keys and the standalone reload fallback. I retain upstream asset hashing and CSP handling.
Related Issue
Refs #196
How I tested this
I ran focused local JavaScript checks and parsed the changed PHP sources for syntax. I have not run the full PHP integration suite, PHPStan, patch-coverage gate or a cross-browser/theme matrix on this prepared version. My tests on my test setup validate the original behavior, not every later cleanup.
Types of changes
I have kept this contribution separate from my other editor and viewer changes.