Skip to content

Handle map duplication when the debug column is absent #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alcatron wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Handle map duplication when the debug column is absent #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28a3f92
Accept map duplication with or without the debug column
alcatron Oct 3, 2026
9c73744
Document handle map duplication when the debug column is absent
alcatron Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ IMPORTANT NOTE: This version only works on CACTI 1.x++!

--- develop ---

* bug: Allow map duplication on installations without the optional debug column

* refactor: Relocate the plugin's database schema provisioning (`weathermap_setup_table()`) out of `setup.php` into a dedicated `includes/database.php` module (function move only, no behaviour change)
* feature: Add a root `manifest.json` file manifest plus an upgrade-time `weathermap_prune_files()` that removes tombstoned and dev-only paths while protecting whitelisted user data (`configs/`, `output/`) and `.git*`, backed by a `tests/bin/validate-manifest.php` CI gate that fails on manifest drift
* dev: Add xdebug coverage reporting to CI and enforce patch coverage of changed lines
Expand Down
4 changes: 3 additions & 1 deletion weathermap-cacti-plugin-mgmt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1936,7 +1936,9 @@ function map_duplicate($id, $titlecache, $configfile = null) {
$save['htmlfile'] = '';
$save['filehash'] = '';
$save['warncount'] = 0;
$save['debug'] = 'off';
if (db_column_exists('weathermap_maps', 'debug')) {
$save['debug'] = 'off';
}
$save['config'] = '';
$save['thumb_height'] = $map['thumb_height'];
$save['thumb_width'] = $map['thumb_width'];
Expand Down