Skip to content

Include permitted picker results and interface descriptions - #275

Open
alcatron wants to merge 1 commit into
Cacti:developfrom
alcatron:fix/editor-picker-results
Open

alcatron wants to merge 1 commit into
Cacti:developfrom
alcatron:fix/editor-picker-results

Conversation

@alcatron

@alcatron alcatron commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Description

Return the full permitted graph/data-source catalog instead of silently limiting browse results to num_rows_table. Include the interface's SNMP ifAlias in data-source labels and search, and URL-encode graph search terms before building the request.

Prepared query parameters and the existing is_graph_allowed filtering are retained.

Related Issue

Closes #272; supports the readable target workflow requested in #42.

Motivation and Context

On my test setup, the default browse lists omitted entries, and interface names alone were difficult to identify. Descriptive, complete results make the existing pickers more useful without changing map configuration formats.

How Has This Been Tested?

  • I tested the picker changes on my test setup running Weathermap 1.7 / Cacti 1.2.31 / PHP 8.3, checking the descriptive interface labels and complete browse lists.
  • Adapted onto current develop while preserving its other changes.
  • JavaScript syntax and git diff whitespace checks passed.
  • Full upstream PHP test suite and permission-matrix integration tests have not been run locally.

Review considerations

Returning the full catalog avoids hidden results but can be expensive on a large installation. Please review whether server-side pagination should be introduced before merge. Automated endpoint coverage, restricted-user scenarios and large-catalog performance remain to be completed.

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • Changelog updated.
  • PHP integration and large-catalog validation completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor pickers omit browse results and interface descriptions

1 participant