Conversation
4 of 7 tasks
alcatron
marked this pull request as ready for review
October 3, 2026 02:53
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Return the full permitted graph/data-source catalog instead of silently limiting browse results to num_rows_table. Include the interface's SNMP ifAlias in data-source labels and search, and URL-encode graph search terms before building the request.
Prepared query parameters and the existing is_graph_allowed filtering are retained.
Related Issue
Closes #272; supports the readable target workflow requested in #42.
Motivation and Context
On my test setup, the default browse lists omitted entries, and interface names alone were difficult to identify. Descriptive, complete results make the existing pickers more useful without changing map configuration formats.
How Has This Been Tested?
Review considerations
Returning the full catalog avoids hidden results but can be expensive on a large installation. Please review whether server-side pagination should be introduced before merge. Automated endpoint coverage, restricted-user scenarios and large-catalog performance remain to be completed.
Types of changes
Checklist