Skip to content

Simplify the common link and node property editing workflow #273

Description

@alcatron

Proposed editor improvement

The link/node property forms expose raw RRD paths, URL fields and low-level controls alongside the everyday interface workflow. A normal traffic link requires separate data-source and graph choices, and generated node IDs make headings and delete confirmations hard to recognise.

I have been testing a compact workflow on my test setup running Weathermap 1.7 / Cacti 1.2.31 installation and would like feedback before it becomes merge-ready:

  • Show the current device/interface/description, with its RRD path underneath (related to Allow Weathermap to remember the Graph names selected as Targets #42).
  • Provide an explicit Use interface action that assigns the traffic target, click destination and hover graph together.
  • Keep bandwidth, link width and IN/OUT comments in the main form; keep Tidy and Via available.
  • Keep display name, icon and position in the main node form.
  • Put raw targets, multiple/external hover graphs, custom click destinations and internal IDs under an explained Advanced section.
  • Retain picker selections on reopening, avoid auto-selecting the first result, and offer Browse all.
  • Separate deletion from Save/Cancel and identify the affected map item by its display name.
  • Explain that node deletion removes its connected map links but does not remove Cacti devices/graphs.

During no-change save testing, I also found that INFOURL query separators are stored as & by the editor sanitizer. The proposed fix preserves query separators while retaining the existing quote/angle-bracket escaping.

The draft will depend on #272 for a complete descriptive picker catalog. Before merge it needs the new strings integrated with the translation conventions in #259, broader browser/theme testing, PHP integration coverage and performance review for large catalogs. This is a proposal for review, not a claim that the entire plugin is production-ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions