ci: run Cacti poller as www-data instead of root - #34
Merged
Merged
Conversation
Re-chown the Cacti tree to www-data:runner right before polling (the CLI install steps run as root and create some files as root), then invoke poller.php via 'sudo -u www-data' so it runs as the actual web/poller user instead of root. This also avoids Cacti core's root-only RRD chown/chgrp path in rrdtool_function_create(), which can log spurious 'does not exist for ownership assignment' warnings for data sources that never produced a value.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Updates the CI workflow to run Cacti’s poller as www-data, matching production behavior.
Changes:
- Reapplies Cacti ownership and permissions.
- Runs
poller.phpaswww-datainstead of root.
File summaries
| File | Summary |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adjusts ownership, permissions, and poller execution user. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Running the poller as www-data (instead of root) exposes that directories above the checkout are typically 750 owned by the runner user, so a non-root www-data process has no 'x' permission to even traverse into them. Root's DAC-bypass previously masked this. Walk up from github.workspace and add o+x to each ancestor directory before polling.
bmfmancini
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test workflow ran \poller.php\ via \sudo\ (root). This re-chowns the Cacti tree to \www-data:runner\ right before polling and runs the poller as \www-data\ instead, matching how Cacti expects the poller to run in production. This also sidesteps Cacti core's root-only RRD ownership-assignment code path in
rdtool_function_create().