Skip to content

ResolveMissingAssembly fallback ineffective because s_assembliesWithResources was never populated #75

Closed

Description

@ByronMayne

Summary

• The resolver's fallback path that searches assemblies for embedded SGF.Assembly:: resources never ran, because s_assembliesWithResources remained empty. As a result embedded assemblies that should have been extracted and returned were not considered, causing assembly resolution failures or incorrect resolution behavior.

Symptoms

• Embedded dependencies (SGF.Assembly::*.dll) are not found by ResolveMissingAssembly; Assembly.Load requests that should have been satisfied by embedded resources throw FileNotFoundException or return null.
• Logs showing "Extracting ..." for the containing assembly appear (when AddAssembly inspects resources), but no subsequent extraction attempts occur via the fallback path.
• Tests or runtime scenarios that rely on the hoist to discover and load embedded assemblies as a fallback will fail intermittently or deterministically when the assembly with the embedded resource was not the one already registered in s_loadedAssemblies.

Impact

• Embedded assembly fallback is non-functional; any scenario where embedded assemblies should be loaded on-demand (rather than eagerly) will fail.
• Causes spurious failures in environments where hoists are loaded into hosts that previously loaded different versions of dependencies (compiler servers, IDEs).
• Makes tests that expect on-demand extraction fail and makes runtime behavior less robust across process lifetimes and ordering of loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions