[iancooper]

Slice 14 of the comment tidy over PR #4039's merge (/refactor:tidy-comments 83e0e5e47^1..83e0e5e47): the provisioning and detection half of tests/Paramore.Brighter.MSSQL.Tests/BoxProvisioning, which includes Drift/, Legacy/ and TestDoubles/. That is the 35 files the merge added, six of them under the names spec 0031 later gave them. Files added after the merge are out of scope.

Commits

• docs:
  • ADR 0057 §3 now records three points:
    • the fresh-install DDL, the ALTERs and detection all target [{schema}].[{table}];
    • operators create the box schema; the runner does not;
    • MSSQL's history-table existence check filters on schema_id.
  • ADR 0057 §3 also corrects where chain contiguity is enforced: at MigrateAsync entry, not at runner construction.
  • ADR 0058 §A.3 says why validators substitute the default schema for a null.
• refactor: tidy comments changes comment lines only:
  • Class narratives become short summaries that cite ADR sections, and AAA markers lose their prose.
  • Comments between assertions, stale version notes, and spec/PR/Item/Phase/reviewer references are removed.
  • The XML docs on internal Drift, Legacy and TestDoubles helpers become // lines.
  • Legacy seeder provenance SHAs are kept.
  • Wrong "ADR 0057 §A.1" references now point at ADR 0058 §A.1.
• refactor: extract methods to express intent:
  • Comment-labelled blocks in the inbox provisioner tests become private helpers.
  • The mid-chain test's commented column literals become constants.
  • The non-monotonic test's commented index list becomes a named static.
  • The vk test's hard-coded 8 becomes ExpectedMigrationVersions.OutboxLatest.

No behaviour changes; tests are otherwise unedited.

Verification

• Paramore.Brighter.MSSQL.Tests --filter BoxProvisioning (net10.0): 94/94 before editing, after each pass, and after merging master.
• Paramore.Brighter.BoxProvisioning.Tests: 119/119 on net9.0 and net10.0.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HsKD52dnGHFLSEr93VZyR7