Repository navigation
fix: stabilize ASP.NET Core test logger initialization - #4571
Merged
iancooper merged 2 commits intoOct 11, 2026
Merged
Conversation
Warm the missing inbox, pipeline builder and transform scope loggers before test hosts can dispose their factories. Isolate SQLite transaction tests so per-instance outbox loggers use a live factory. Fixes BrighterCommand#4565. Validated with 20 full suite runs per framework on .NET 9 and .NET 10 (2,600 passing test executions).
gabisonia
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
October 9, 2026 18:10
Member
|
Thanks @gabisonia |
iancooper
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallel ASP.NET Core tests can initialize a Brighter logger after another test host has disposed the shared logger factory. Warm the missing inbox handlers, pipeline builders and transform lifetime scope in the module initializer so their static loggers bind to the stable test factory.
The three SQLite transaction tests also create outbox loggers per instance. Put those tests in a non-parallel collection so their existing factory reset is safe during outbox construction. Other test classes remain parallel.
Related Issues
Fixes #4565
Type of Change
Checklist
Additional Notes
Please merge with a merge commit, per the contributing guide.