Repository navigation
Conversation
lillo42
approved these changes
Apr 28, 2026
isakovich
marked this pull request as ready for review
April 29, 2026 09:26
isakovich
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
April 29, 2026 09:26
Member
|
@isakovich Could you sign the CLA (you keep the IP, you just license it to us) |
iancooper
reviewed
May 1, 2026
iancooper
left a comment
Member
There was a problem hiding this comment.
Looks good, but I need you to sign the CLA. It protects you, as much as us.
isakovich
force-pushed
the
fix/preserve-json-serializer-options
branch
from
May 3, 2026 07:46
d86300b to
51fac81
Compare
Member
|
@isakovich Held up because our build breaks due to an advisory being issued by GHA against Snappier, which our MongoDb drivers depend on. See mongodb/mongo-csharp-driver#1989 Once we can get a fix, and we can get builds again, we can move forward. I assume it will be soon. |
There was a problem hiding this comment.
Gates Passed
4 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
ConfigureJsonSerialisationto preserve existingJsonSerializerOptionsinstead of overriding them with a new instance. The current implementation instantiates a newJsonSerializerOptionsobject, discarding any previously configured settings. This change ensures existing configuration is preserved while adding/modifying JustSaying-specific options.Related Issues
Type of Change
Checklist
Additional Notes
Added tests to verify that JustSaying message properties (Id, Conversation, RaisingComponent, Tenant, Version, TimeStamp) are preserved during serialization and not overwritten, including scenarios where properties come from the request context or publication.