feat(atb2): add Slack intake and approved babysitter fixes - #4766
Draft
ATX24 wants to merge 6 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack mentions now enter the feedback runner through a signed HTTP endpoint.
@bammy babysit <PR URL>investigates CI failures and review comments, posts a proposed fix in the Slack thread, and links to a private proposal page. An explicitly mapped shepherd can approve the exact Slack message; website approval requires current GitHub maintain/admin access. Requester status alone grants no approval rights.Each approval authorizes one implementation, test gate and push, bound to the PR head and feedback. Approval is consumed atomically; changed feedback or a changed head requires a new proposal. The runner announces the push in Slack before updating the branch with an explicit lease. Later review feedback requires another approval. The final message reports CI and reviewer-feedback status without automatically merging or posting review-bot resolve commands.
Also includes shepherd approval for newly triaged issues, website status badges and private proposal/authentication routes, Fly HTTP intake, and root-only Infisical Universal Auth using the existing machine identity. CLI update notices (part 6) are outside this PR.
Security boundaries:
Validation:
Remaining deployment risks:
Keep this PR in draft while those deployment blockers are reviewed. Merging changes tools/atb2 and triggers the canary Fly deployment workflow when FLY_API_TOKEN is present.
Deployment/setup:
Earlier Slack schema additions (owner reported applied):
Additional proposal schema (not yet applied):