fix(browser): don't paint an error over a live stream

[philmerrell]

What

The DCV SDK closes the auth WebSocket as soon as it is finished with it, and reports that close through the error callback even though authentication succeeded.

Measured on dev, with a single mint so nothing else is in play:

23:32:58.148  [connection] WARN ...          <- connect() ALREADY running
              WebSocket .../auth failed: Close received after close
              dcv.authenticate failed {code: 10}
23:32:58.456  [connectionmanager] Added connection 1
23:32:58.467  [dcv::display:1] ...
23:32:59.177  [dcv::input:1] ...

connect is running before the error arrives — so success fired first, and the stream establishes normally afterwards. In Node the identical close is a clean code 1000; Chrome surfaces it as a socket error.

#status is an absolutely-positioned overlay covering the whole display, so the handler was painting "Could not start the session. It may have ended." across a working stream. It also cleared starting, so a later post could open a second one.

Fix

Ignore an auth error once a session exists. A genuine pre-session failure still reports, and a disconnect resets the flag so a later attempt can fail loudly again.

This retires the code 10

I treated dcv.authenticate failed {code: 10} as a service fault for several rounds. It was never a failure — it is the SDK reporting its own cleanup. Two things made it convincing: it is logged at error level with "Failed to communicate with server", and the stream it belonged to was genuinely broken at the time for four unrelated reasons (#1190, #1192, #1194, #1196). Once those were fixed the message stayed, because it had never been a symptom of any of them.

The tell was always in the ordering — connect running before the error — and I only saw it after #1199 removed the second mint that was muddying the sequence.

Tests

Asserts an error after success leaves the status clear, and that a pre-session failure still surfaces.

Mutation-checked: removing the guard fails the new assertion. Suite 880 pass, tsc --noEmit clean.

🤖 Generated with Claude Code