Skip to content

feat(composer): park the Conversation Mode picker - #1088

Merged
philmerrell merged 1 commit into
developfrom
feature/park-conversation-mode-picker
Sep 13, 2026
Merged

philmerrell merged 1 commit into
developfrom
feature/park-conversation-mode-picker

Conversation

@philmerrell

Copy link
Copy Markdown
Contributor

Removes ConversationModePickerComponent from the composer and deletes it. The placement works — I verified it end to end on dev before pulling it — but a permanent composer slot is a bigger commitment than the evidence currently supports, so it comes out until there is user feedback to decide the location on.

Only the control is removed

Everything behind it is untouched and still live:

Layer State
Admin CRUD /admin/system-prompts unchanged
GET /system-prompts/ catalog unchanged
SystemPromptsService (load, active-prompt tracking, step-5 hydration fix) intact
selected_prompt_id on SessionPreferences intact, still round-trips
The picker component deleted

So restoring this is git revert on one commit, not a rebuild — and re-homing it elsewhere starts from a tested component rather than a blank file.

⚠️ Release gate — please read before the next release to main

origin/main still carries components/model-settings/. The Customize epic has not reached prod, so prod users select Guided Learning through the old drawer today — ~60 sessions in the first 12 days of September and accelerating.

develop deletes that drawer (#1079) and, after this PR, has no picker. The first release carrying both to prod therefore ships no way to select a Conversation Mode at all, silently killing a feature in active growth.

Before that release: restore the picker, land a replacement placement, or take the regression knowingly and tell @derrickfink. This is recorded in docs/specs/customize-surface.md so it surfaces at release time rather than after.

Placements still on the table

Conversation title menu · inside the model dropdown · new-chat empty state · a /mode inline command (copy agent-mention-menu.component.ts) · generalising the assistant indicator — which today renders only when an Agent is bound (topnav.html:140), so it cannot host Mode as-is.

Verification

  • 2842 tests / 240 files pass; production build clean.
  • The obvious browser check was worthless and I want to flag why: localhost:4200 points at a local app-api whose prompt catalog is empty, so the chip would be absent there whether or not anything changed.
  • The check that actually proves it: the picker's strings return 0 matches in dist/, against a control string returning 3. The control cannot render for anyone, regardless of catalog contents.
  • Two seeded modes are deliberately left enabled on dev so the feature can be re-exposed without re-seeding.

🤖 Generated with Claude Code

Removes ConversationModePickerComponent from the composer and deletes it.
The placement works — verified end to end on dev — but a permanent composer
slot is a bigger commitment than the evidence currently supports, so it comes
out until there is user feedback to decide the location on.

Only the control is removed. SystemPromptsService, GET /system-prompts/,
selected_prompt_id on SessionPreferences and the admin CRUD are all untouched,
so restoring this is a revert rather than a rebuild.

Release gate, recorded in the spec: main still carries the model-settings
drawer, which is how prod selects Guided Learning today (~60 sessions/month
and growing). develop deletes that drawer and now has no picker, so the first
release carrying both leaves no way to select a mode at all. Restore the
picker, land a replacement placement, or take the regression knowingly before
that release ships.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@philmerrell
philmerrell merged commit 949f849 into develop Sep 13, 2026
6 checks passed
@philmerrell
philmerrell deleted the feature/park-conversation-mode-picker branch September 13, 2026 15:46
@philmerrell philmerrell mentioned this pull request Sep 14, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant