feat(composer): park the Conversation Mode picker - #1088
Merged
Merged
Conversation
Removes ConversationModePickerComponent from the composer and deletes it. The placement works — verified end to end on dev — but a permanent composer slot is a bigger commitment than the evidence currently supports, so it comes out until there is user feedback to decide the location on. Only the control is removed. SystemPromptsService, GET /system-prompts/, selected_prompt_id on SessionPreferences and the admin CRUD are all untouched, so restoring this is a revert rather than a rebuild. Release gate, recorded in the spec: main still carries the model-settings drawer, which is how prod selects Guided Learning today (~60 sessions/month and growing). develop deletes that drawer and now has no picker, so the first release carrying both leaves no way to select a mode at all. Restore the picker, land a replacement placement, or take the regression knowingly before that release ships. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ConversationModePickerComponentfrom the composer and deletes it. The placement works — I verified it end to end on dev before pulling it — but a permanent composer slot is a bigger commitment than the evidence currently supports, so it comes out until there is user feedback to decide the location on.Only the control is removed
Everything behind it is untouched and still live:
/admin/system-promptsGET /system-prompts/catalogSystemPromptsService(load, active-prompt tracking, step-5 hydration fix)selected_prompt_idonSessionPreferencesSo restoring this is
git reverton one commit, not a rebuild — and re-homing it elsewhere starts from a tested component rather than a blank file.origin/mainstill carriescomponents/model-settings/. The Customize epic has not reached prod, so prod users select Guided Learning through the old drawer today — ~60 sessions in the first 12 days of September and accelerating.developdeletes that drawer (#1079) and, after this PR, has no picker. The first release carrying both to prod therefore ships no way to select a Conversation Mode at all, silently killing a feature in active growth.Before that release: restore the picker, land a replacement placement, or take the regression knowingly and tell @derrickfink. This is recorded in
docs/specs/customize-surface.mdso it surfaces at release time rather than after.Placements still on the table
Conversation title menu · inside the model dropdown · new-chat empty state · a
/modeinline command (copyagent-mention-menu.component.ts) · generalising the assistant indicator — which today renders only when an Agent is bound (topnav.html:140), so it cannot host Mode as-is.Verification
dist/, against a control string returning 3. The control cannot render for anyone, regardless of catalog contents.🤖 Generated with Claude Code