Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Fix HIGHFIVE_VERSION. - #719

Merged
1uc merged 8 commits into
masterfrom
1uc/fix-version-string
Apr 4, 2023
Merged

1uc merged 8 commits into
masterfrom
1uc/fix-version-string

Conversation

@1uc

@1uc 1uc commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

This fixes two issues:

  • HIGHFIVE_VERSION should be a string literal. (Used to be something invalid.)
  • The build system didn't include the *_BINARY_DIR/include for local builds. The generated file was installed.

See #715 for the initial contribution and more information.

@1uc

1uc commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator Author

Double check that the file did get installed:

-- Installing: [...]/include/highfive/H5Version.hpp

@codecov

codecov Bot commented Apr 3, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #719 (b80a853) into master (559bd85) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   82.38%   82.42%   +0.03%     
==========================================
  Files          67       67              
  Lines        4503     4513      +10     
==========================================
+ Hits         3710     3720      +10     
  Misses        793      793              
Impacted Files Coverage Δ
tests/unit/tests_high_five_base.cpp 99.66% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matz-e
matz-e previously approved these changes Apr 3, 2023
@1uc
1uc marked this pull request as ready for review April 4, 2023 05:31
@1uc
1uc merged commit 2759770 into master Apr 4, 2023
@1uc
1uc deleted the 1uc/fix-version-string branch April 4, 2023 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants