This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Repository navigation
Fix HIGHFIVE_VERSION. - #719
Merged
Merged
Conversation
Collaborator
Author
|
Double check that the file did get installed: |
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 82.38% 82.42% +0.03%
==========================================
Files 67 67
Lines 4503 4513 +10
==========================================
+ Hits 3710 3720 +10
Misses 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matz-e
previously approved these changes
Apr 3, 2023
alkino
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
HIGHFIVE_VERSIONshould be a string literal. (Used to be something invalid.)*_BINARY_DIR/includefor local builds. The generated file was installed.See #715 for the initial contribution and more information.