Conversation
Arvolear
commented
Aug 7, 2026
Arvolear
commented
Member
- This PR suggests a bug fix and I've added the necessary tests.
- This PR introduces a new feature and I've discussed the update in an Issue or with the team.
- This PR is just a minor change like a typo fix.
CI runs `cargo clippy --workspace --all-targets --all-features` under `RUSTFLAGS: -Dwarnings`, so a pedantic warning fails the build. This branch carried twenty-two of them: six in the SDK and sixteen in the binding. Most are mechanical — backticks around SimplicityHL, OP_RETURN and BitMachine in prose, `#[must_use]` on three accessors that return a value and touch nothing, `if let` where a `match` destructured a single pattern. Two are judgement calls, both recorded where they are made. `Option<String>` stays on the four binding entry points clippy wants borrowed. wasm-bindgen implements no `OptionFromWasmAbi` for `&str`, so an optional string argument has to arrive owned; the alternative is not a nicer signature but a crate that does not compile. The allow sits on each function with the reason above it rather than at the crate root, so a genuine case elsewhere still fails. `required_signature` stops returning `Result`. It parses a name it has already proved non-empty and has no failing path, and a `?` at its call site claimed otherwise. `add_contract_input` keeps its nine arguments: it is the binding surface a caller reaches for, and folding them into a parameter object would move the shape into JavaScript for a lint. Claude-Session: https://claude.ai/code/session_0133RUq5DKdBerk4ypVdpAZK
Pass the workspace clippy gate with warnings denied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.