Skip to content

debian package building added - #1675

Closed
navjotcis wants to merge 4 commits into
Bitmessage:v0.6from
navjotcis:bug-fixes8
Closed

debian package building added#1675
navjotcis wants to merge 4 commits into
Bitmessage:v0.6from
navjotcis:bug-fixes8

Conversation

@navjotcis

Copy link
Copy Markdown
Contributor

@navjotcis navjotcis mentioned this pull request Sep 25, 2020
@PeterSurda

Copy link
Copy Markdown
Member

I tested, it builds, but haven't tried installing.

@PeterSurda

Copy link
Copy Markdown
Member

I would say I merge this and if it doesn't run, fix it separately, because having this in will allow me to add dpkg to buildbot.

@PeterSurda PeterSurda self-assigned this Oct 12, 2020
@PeterSurda PeterSurda added build Related to building or build system packaging labels Oct 12, 2020
@PeterSurda PeterSurda added this to the v0.6.4 milestone Oct 12, 2020
@g1itch

g1itch commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

Why don't you put this into packages dir?

@PeterSurda

PeterSurda commented Oct 12, 2020

Copy link
Copy Markdown
Member

I don't know how to integrate it into dpkg-buildpackage if I move the files.

Comment thread debian/rules Outdated
@g1itch

g1itch commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

@g1itch

g1itch commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

@navjotcis

Copy link
Copy Markdown
Contributor Author

Now the build is successfully passing https://buildbot.bitmessage.org/#/builders/14/builds/161

@g1itch

g1itch commented Oct 14, 2020

Copy link
Copy Markdown
Collaborator

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

@navjotcis

Copy link
Copy Markdown
Contributor Author

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

so I think I should use stable version like you have used bitmessage (0.6.3.2) stable; urgency=medium

@g1itch

g1itch commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

Also, please, look into informational part. Why empty fields? Why such weird version and unstable mark? Should python-msgpack really be a requirement? Who is going to be maintainer and how it will be maintained? Changelog may be probably generated by sphinx.

so I think I should use stable version like you have used bitmessage (0.6.3.2) stable; urgency=medium

You can get actual version by python setup.py -V but it's not the point. For me the real problem with this PR is that it tends to become another unusable piece of garbage like fabfile, android_instruction.rst, src/bitmessagekivy, src/kivymd, src/navigationdrawer and like docs was before I fixed the documentation building process. You have some additional scripts in buildbot/dpkg task, including one, changing the version, which is needed for deb building. But your README says "Clone the source and run dpkg-buildpackage" and that's not gonna work for a general end user.

@g1itch

g1itch commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903

Amendment: something like that, but demonstrating the build of non-empty and functional deb.

@g1itch

g1itch commented Oct 15, 2020

Copy link
Copy Markdown
Collaborator

That's what I expected: https://travis-ci.org/github/g1itch/PyBitmessage/builds/735505903

Amendment: something like that, but demonstrating the build of non-empty and functional deb.

Like this: https://travis-ci.org/github/g1itch/PyBitmessage/jobs/736037581

As I suspected all that debian dir indeed is garbage. stdeb.cfg is enough. If someone needs that dir for some reason, it's generated by python setup.py --command-packages=stdeb.command debianize.

@PeterSurda

PeterSurda commented Oct 30, 2020

Copy link
Copy Markdown
Member

@g1itch Can you make a minimal PR from your debian branch? Then we can close this. No need to modify .travis.yml, I want the builds and the tests to be separate. As you can see buildbot's dpkg builder now succeeds, so it just needs fine tuning.

@PeterSurda

Copy link
Copy Markdown
Member

Superseded by #1686 .

@PeterSurda PeterSurda closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to building or build system documentation legal packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants