Skip to content

winebuild.sh updates - #1663

Merged
PeterSurda merged 3 commits into
Bitmessage:v0.6from
PeterSurda:winebuild4
Aug 30, 2020
Merged

winebuild.sh updates#1663
PeterSurda merged 3 commits into
Bitmessage:v0.6from
PeterSurda:winebuild4

Conversation

@PeterSurda

@PeterSurda PeterSurda commented Aug 27, 2020

Copy link
Copy Markdown
Member

- remove SSL certificate from winebuild.sh (was causing too many
problems, not worth the effort)
- set pytools version to 2020.2 in winebuild.sh, as that's the last one
to support python2
- fixes Bitmessage#1658
- code quality only changes
@PeterSurda PeterSurda added formatting Code or UI text formatting build Related to building or build system labels Aug 27, 2020
@PeterSurda PeterSurda added this to the v0.6.4 milestone Aug 27, 2020
@PeterSurda
PeterSurda requested a review from g1itch August 28, 2020 07:59
@g1itch

g1itch commented Aug 28, 2020

Copy link
Copy Markdown
Collaborator

I cannot build ):

Collecting pyinstaller
  Downloading pyinstaller-4.0.tar.gz (3.5 MB)
     |████████████████████████████████| 3.5 MB 806 kB/s eta 0:00:01
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  ERROR: Command errored out with exit status 1:
   command: 'C:\Python27\python.exe' 'C:\Python27\lib\site-packages\pip\_vendor\pep517\_in_process.py' get_requires_for_build_wheel 'c:\users\glitch\temp\tmpikxa_7'
       cwd: c:\users\glitch\temp\pip-install-_nlzwo\pyinstaller
  Complete output (19 lines):
  Traceback (most recent call last):
    File "C:\Python27\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 280, in <module>
      main()
    File "C:\Python27\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 263, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "C:\Python27\lib\site-packages\pip\_vendor\pep517\_in_process.py", line 114, in get_requires_for_build_wheel
      return hook(config_settings)
    File "c:\users\glitch\temp\pip-build-env-40x1_r\overlay\Lib\site-packages\setuptools\build_meta.py", line 146, in get_requires_for_build_wheel
      return self._get_build_requires(config_settings, requirements=['wheel'])
    File "c:\users\glitch\temp\pip-build-env-40x1_r\overlay\Lib\site-packages\setuptools\build_meta.py", line 127, in _get_build_requires
      self.run_setup()
    File "c:\users\glitch\temp\pip-build-env-40x1_r\overlay\Lib\site-packages\setuptools\build_meta.py", line 243, in run_setup
      self).run_setup(setup_script=setup_script)
    File "c:\users\glitch\temp\pip-build-env-40x1_r\overlay\Lib\site-packages\setuptools\build_meta.py", line 142, in run_setup
      exec(compile(code, __file__, 'exec'), locals())
    File "setup.py", line 63
      file=sys.stderr)
          ^
  SyntaxError: invalid syntax
  ----------------------------------------
ERROR: Command errored out with exit status 1: 'C:\Python27\python.exe' 'C:\Python27\lib\site-packages\pip\_vendor\pep517\_in_process.py' get_requires_for_build_wheel 'c:\users\glitch\temp\tmpikxa_7' Check the logs for full command output.
Create dll
wine: cannot find L"C:\\windows\\system32\\pyinstaller.exe"

@g1itch

g1itch commented Aug 28, 2020

Copy link
Copy Markdown
Collaborator

PyInstaller 3.6 is the last version supporting python2: https://github.com/pyinstaller/pyinstaller/releases

@PeterSurda

Copy link
Copy Markdown
Member Author

Ok I'll force a pyinstaller version

- pyinstaller 3.6 is the last one supporting python 2.7 so we're forcing
it for 64bit windows builds
@PeterSurda
PeterSurda merged commit 39d28b9 into Bitmessage:v0.6 Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to building or build system formatting Code or UI text formatting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows build python 2 compatibility

2 participants