Repository navigation
Demo notebooks - #29
Merged
Merged
Conversation
mattersoflight
self-requested a review
August 10, 2023 15:23
* readme + dependencies tested with python 3.10 * match package description with README * cellpose (metrics -> required) * misc formatting and language edits * fix optional dependency on cellpose --------- Co-authored-by: Ziwen Liu <ziwen.liu@czbiohub.org>
ziw-liu
commented
Aug 10, 2023
| log_num_samples=10, | ||
| ) | ||
|
|
||
| trainer = VSTrainer( |
Collaborator
There was a problem hiding this comment.
I think we should write the logs in pwd, such that the folder structure is 04-image-translation/setup.sh, 04-image-translation/viscy, 04-image-translation/lightning_logs, ...
| accelerator="gpu", max_epochs=20, log_every_n_steps=10, default_root_dir="" | ||
| ) | ||
|
|
||
| trainer.fit(model, datamodule=data_module) |
Collaborator
There was a problem hiding this comment.
I am seeing this error: PossibleUserWarning: The number of training batches (8) is smaller than the logging interval Trainer(log_every_n_steps=10). et a lower value for log_every_n_steps if you want to see logs for the training epoch.
Following the suggestion.
| log_num_samples=10, | ||
| ) | ||
|
|
||
| trainer = VSTrainer( |
Collaborator
There was a problem hiding this comment.
Current logger writes events from two traning runs to the same directory. The tensorboard logs written like this can be confusing for novice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: