FIR-572 update bb usb implementation to utilize tinyusb uninstall - #14
Merged
shogo-sugihara merged 5 commits intoDec 23, 2024
Conversation
finger563
approved these changes
Dec 13, 2024
Author
|
With the Niji connected to iPhone 15, I was able to plug and unplug the headset plug 500 times without any crashes. |
finger563
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for preliminary code review.
This PR solves the following issue:
https://linear.app/backbonelabs/issue/FIR-572/update-bb-usb-implementation-to-utilize-tinyusb-uninstall
At this time, operation has only been confirmed on Android Pixel5 phone.
The Apple Auth IC in my preEVT sample is broken (This is the only Auth IC on the I2C_400K bus that does not return an ACK.), so I will have Minagawa-san repair it on next Monday.
Therefore, operation has not yet been confirmed on iPhone.
This change will completely disable DCD on tinyusb driver uninstall.
This change will be combined with the changes in the niji repository.