Skip to content

Allow portalocker 2 on Python 3.5+ - #97

Merged
Ray Luo (rayluo) merged 1 commit into
devfrom
allow-portalocker-2
Aug 30, 2021
Merged

Allow portalocker 2 on Python 3.5+#97
Ray Luo (rayluo) merged 1 commit into
devfrom
allow-portalocker-2

Conversation

@rayluo

Copy link
Copy Markdown
Contributor

Thanks Dave Hirschfeld (@dhirschfeld) for bringing #94 to our attention. It turns out, our attempt in #95 was not quite there yet, so my offline trial-and-error led me to this PR. It should work, and it will close #94 and close #95.

P.S.: After merging this PR, the change will not immediately go live, but it will be included in our next release.

@dhirschfeld

Copy link
Copy Markdown

Thanks for following through & figuring it out Ray Luo (@rayluo)! ❤️

@rayluo
Ray Luo (rayluo) merged commit 26240cb into dev Aug 30, 2021
@rayluo
Ray Luo (rayluo) deleted the allow-portalocker-2 branch August 30, 2021 16:14
@dhirschfeld

Copy link
Copy Markdown

It looks like this didn't make it into the 0.3.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support portalocker >=2

2 participants