Adds Embedded Sources and enable deterministic builds for Core module - #1656
Merged
Aniruddh Munde (Aniruddh25) merged 6 commits intoAug 26, 2023
Merged
Conversation
Shyam Sundar J (severussundar)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Abhishek Kumar (abhishekkumams),
Ayush Agarwal (ayush3797),
Gledis Zeneli (gledis69),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Ravi Shetye (ravishetye),
Sean Leonard (seantleonard) and
tarazou9
as code owners
August 25, 2023 15:57
Shyam Sundar J (severussundar)
changed the title
1 task
Sean Leonard (seantleonard)
approved these changes
Aug 25, 2023
Sean Leonard (seantleonard)
left a comment
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
thanks for adding. one question.
Aniruddh Munde (Aniruddh25)
approved these changes
Aug 25, 2023
Aniruddh Munde (Aniruddh25)
left a comment
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for noticing this and fixing it!
Aniruddh Munde (Aniruddh25)
enabled auto-merge (squash)
August 25, 2023 23:36
Aniruddh Munde (Aniruddh25)
added a commit
that referenced
this pull request
Aug 25, 2023
## Why make this change? - Closes #1655 - The `SourceLink` NuGet health property is not `valid` due to the absence of SourceLink dependency ## What is this change? - `SourceLink` dependency is added to the `Product` module - `SourceLink` embeds the git commit ID to assembly metadata. So, the application name will be of the form `dab_oss_1.0.0+<commit_id>`. So, test assertion logic is updated. - This PR is a subsequent change for [PR #1656 ](#1656). It describes why the changes for fixing the NuGet health are broken down into two separate PRs. ## How was this tested? - [x] Manual Tests. Health of the NuGet after applying the changes from this PR and [PR #1656 ](#1656) was validated.  Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Aniruddh Munde (Aniruddh25)
deleted the
dev/shyamsundarj/fix-nupkg-health
branch
August 26, 2023 00:56
Aniruddh Munde (Aniruddh25)
added a commit
that referenced
this pull request
Aug 26, 2023
…#1656) ## Why make this change? - Closes #1655 - Health of [0.8.44-rc nupkg](https://nuget.info/packages/Microsoft.DataApiBuilder/0.8.44-rc) nupkg needs to be fixed ## What is this change? - To fix the NuGet generated in the `main` branch, `Product` and `Core` modules needs to be updated. `Product` module was introduced later and `0.8.*` NuGets do not have the Product module. So, the fix is broken into two PRs. - This PR adds changes only to the `Core` module. After merging to `main`, this PR can be ported over to `release/0.8` branch. - [PR #1657 ](#1657) adds the changes to `Product` module. - Sets `EmbedUntrackedSources` and `ContinuousIntegrationBuild` to `true` ## How was this tested? - [x] Manual Tests By applying the change on top of the `release/0.8` branch, the health of the NuGet generated was validated  --------- Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
1 task
Aniruddh Munde (Aniruddh25)
added a commit
that referenced
this pull request
Aug 26, 2023
…for Core module… (#1660) Cherry-Picks (#1656) to release/0.8 branch **Original Description:** ## Why make this change? - Closes #1655 - Health of [0.8.44-rc nupkg](https://nuget.info/packages/Microsoft.DataApiBuilder/0.8.44-rc) nupkg needs to be fixed ## What is this change? - To fix the NuGet generated in the `main` branch, `Product` and `Core` modules needs to be updated. `Product` module was introduced later and `0.8.*` NuGets do not have the Product module. So, the fix is broken into two PRs. - This PR adds changes only to the `Core` module. After merging to `main`, this PR can be ported over to `release/0.8` branch. - [PR #1657 ](#1657) adds the changes to `Product` module. - Sets `EmbedUntrackedSources` and `ContinuousIntegrationBuild` to `true` ## How was this tested? - [x] Manual Tests By applying the change on top of the `release/0.8` branch, the health of the NuGet generated was validated  --------- Co-authored-by: Shyam Sundar J <shyamsundarj@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
To fix the NuGet generated in the
mainbranch,ProductandCoremodules needs to be updated.Productmodule was introduced later and0.8.*NuGets do not have the Product module. So, the fix is broken into two PRs.This PR adds changes only to the
Coremodule. After merging tomain, this PR can be ported over torelease/0.8branch.PR #1657 adds the changes to
Productmodule.Sets
EmbedUntrackedSourcesandContinuousIntegrationBuildtotrueHow was this tested?
By applying the change on top of the
release/0.8branch, the health of the NuGet generated was validated