[Packaging] Support ARM64 on Linux - #24180
Conversation
ghost
added
the
|
Really long-awaited feature to support ARM64, good job! |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| rpmbuild -v -bb --clean scripts/release/rpm/azure-cli.spec && \ | ||
| cp /root/rpmbuild/RPMS/x86_64/azure-cli-${cli_version}-1.*.x86_64.rpm /azure-cli-dev.rpm | ||
| cp /root/rpmbuild/RPMS/**/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \ | ||
| mkdir /out && cp /root/rpmbuild/RPMS/**/azure-cli-${cli_version}-1.*.rpm /out/ |
There was a problem hiding this comment.
docker cp does not support wildcard, move target package to out folder.
| Package: azure-cli | ||
| Architecture: all | ||
| Architecture: any | ||
| Depends: \${shlibs:Depends}, \${misc:Depends} |
There was a problem hiding this comment.
This also change deb package name from all.deb to amd64.deb
There was a problem hiding this comment.
The package size also decrease by 20MB.
Specifying only any indicates that the source package isn’t dependent on any particular architecture and should compile fine on any one. The produced binary package(s) will be specific to whatever the current build architecture is.
Specifying only all indicates that the source package will only build architecture-independent packages.
https://www.debian.org/doc/debian-policy/ch-controlfields.html
| exit 0 | ||
| fi | ||
| # https://docs.docker.com/engine/security/rootless/ | ||
| /bin/bash -c "$(curl -fsSL https://get.docker.com)" |
There was a problem hiding this comment.
I strongly feel we should persuade 1ES to provide an image with docker, instead of installing docker by ourselves.
There was a problem hiding this comment.
Hope this issue will be fixed one day. actions/runner-images#5631
| fi | ||
| fi | ||
| echo "deb [arch=amd64] https://packages.microsoft.com/repos/azure-cli/ ${CLI_REPO} main" \ | ||
| echo "deb [arch=$(dpkg --print-architecture)] https://packages.microsoft.com/repos/azure-cli/ ${CLI_REPO} main" \ |
| ${TAB}mkdir -p debian/azure-cli/etc/bash_completion.d/ | ||
| ${TAB}cat ${completion_script} > debian/azure-cli/etc/bash_completion.d/azure-cli | ||
| ${TAB}dpkg-shlibdeps -v --warnings=7 -Tdebian/azure-cli.substvars -dDepends -edebian/azure-cli/opt/az/bin/python3 debian/azure-cli/opt/az/lib/python3.10/lib-dynload/_ssl.cpython-310-x86_64-linux-gnu.so | ||
| ${TAB}ssl_file=$(find debian/azure-cli/opt/az/lib/python3.10/ -type f -name '_ssl.cpython-310-*-linux-gnu.so') |
There was a problem hiding this comment.
Perhaps we don't need to use find, similar to #24180 (comment).
| rpmbuild -v -bb --clean scripts/release/rpm/azure-cli.spec && \ | ||
| cp /usr/src/mariner/RPMS/x86_64/azure-cli-${cli_version}-1.cm2.x86_64.rpm /azure-cli-dev.rpm | ||
| cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \ | ||
| mkdir /out && cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /out/ |
There was a problem hiding this comment.
Any reason for copying to /out?
There was a problem hiding this comment.
In scripts/release/rpm/pipeline.sh, we'll copy the rpm file with docker cp $id:/out/. ${BUILD_STAGINGDIRECTORY} later.
RPMs are in different folders on amd64 and arm64, but docker cp does not support wildcard. I move target package to out folder.
28a951b to
322091f
Compare
|
Any timeline for this to be released? |
|
Travis Plunk (@TravisEz13) On March 07 |
5 participants
Description
The long-awaited feature is finally here. The ARM64 build will be released for current supported Linux distribution.
Close #7368
Related issue: #22875
Main changes:
-amd64or-arm64suffix.all.debtoamd64.deb/arm64.deb.Architecture: anyinscripts/release/debian/prepare.sh.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.