Skip to content

[AKS] sdk update - #18031

Merged
Feng Zhou (fengzhou-msft) merged 10 commits into
Azure:devfrom
haitch:haitao/aks-sdk-update
May 12, 2021
Merged

[AKS] sdk update#18031
Feng Zhou (fengzhou-msft) merged 10 commits into
Azure:devfrom
haitch:haitao/aks-sdk-update

Conversation

@haitch

@haitch Haitao Chen (haitch) commented May 11, 2021

Copy link
Copy Markdown
Contributor

Description

To bump AKS SDK dependency version, future PR will consume this newer version of SDK.

Testing Guide

update all recordings, existing test are working fine.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@northtyphoon

Copy link
Copy Markdown
Member

Haitao Chen (@haitch), does the pr include any change related to ACR? If yes, can you point me to the code?

@haitch

Copy link
Copy Markdown
Contributor Author

Haitao Chen (@haitch), does the pr include any change related to ACR? If yes, can you point me to the code?

nevermind, the initial version have ACR recording file updated as well, I reverted those.

@fengzhou-msft
Feng Zhou (fengzhou-msft) merged commit 5434b87 into Azure:dev May 12, 2021
@xfz11

xfz11 commented May 13, 2021

Copy link
Copy Markdown
Contributor

Hi, the PR caused aks-preview extension test failed. Pls take a look

@FumingZhang

Copy link
Copy Markdown
Member

Haitao Chen (@haitch), xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

@xfz11

xfz11 commented May 14, 2021

Copy link
Copy Markdown
Contributor

Yunge Zhu (@yungezz)

@yungezz

Copy link
Copy Markdown
Member

Haitao Chen (@haitch), xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

hi Haitao Chen (@haitch) this PR caused Azure CLI extension repo CI test failed, it blocks PRs in extension repo. Could you pls fix aks extension tests to make CI pass?

@haitch

Copy link
Copy Markdown
Contributor Author

We have a fix PR pending to be merged: Azure/azure-cli-extensions#3378

Haitao Chen (@haitch), xfz11 the updated sdk version (11.2.0) make delete request with api version 2021-03-01 now, however the recordings in aks-preview records request with api version 2021-02-01. So this pr change is breaking aks-preview tests

hi Haitao Chen (@haitch) this PR caused Azure CLI extension repo CI test failed, it blocks PRs in extension repo. Could you pls fix aks extension tests to make CI pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants