Skip to content

Fix for Fairfax ExtType calls landing on Prod ARM URL - #9726

Open
prasannajsns wants to merge 1 commit into
Azure:mainfrom
prasannajsns:japras/fix-exttypes-ff-url
Open

Fix for Fairfax ExtType calls landing on Prod ARM URL#9726
prasannajsns wants to merge 1 commit into
Azure:mainfrom
prasannajsns:japras/fix-exttypes-ff-url

Conversation

@prasannajsns

@prasannajsns prasannajsns commented Mar 26, 2026

Copy link
Copy Markdown
Member

Fixes an issue where az k8s-extension extension-types commands in Fairfax are routed to public ARM URL

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings March 26, 2026 07:36
@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Mar 26, 2026

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi prasannajsns,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions

Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions

Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a hard-coded ARM base URL override in the vendored SourceControlConfiguration client so that az k8s-extension extension-types requests respect the Azure CLI cloud’s configured Resource Manager endpoint (e.g., Fairfax) instead of always targeting the public ARM endpoint.

Changes:

  • Removed a temporary _client._base_url = "https://management.azure.com" override from the extension_types operation group accessor.
  • Eliminated the associated “remove after testing” comment for 2023-05-01-preview.

@github-actions

Copy link
Copy Markdown
Contributor

Hi prasannajsns

Release Suggestions

Module: k8s-extension

  • Please log updates into to src/k8s-extension/HISTORY.rst
  • Update VERSION to 1.7.1 in src/k8s-extension/setup.py

Notes

@prasannajsns

prasannajsns commented Mar 29, 2026

Copy link
Copy Markdown
Member Author

Julie Zhu (@yanzhudd) - could you please approve this PR? my team members tried but unable to approve.

Yong Zhang (@yonzhan) - any other reviewers that could approve this PR? The styling errors are from previous content not added/modified by this PR.

@yanzhudd

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd

Copy link
Copy Markdown
Contributor

please resolve the CI issues

@prasannajsns

Copy link
Copy Markdown
Member Author

please resolve the CI issues

Julie Zhu (@yanzhudd) - The CI check failures are styling issue in the previously existing code and not newly introduced. We will address them in our next update to the CLI package. Please approve this PR if there are no other comments from your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants