Skip to content

[confcom] changing version number naming scheme and bugfix for 32bit python - #6144

Merged
kai ru (kairu-ms) merged 21 commits into
Azure:mainfrom
SethHollandsworth:main
May 8, 2023
Merged

[confcom] changing version number naming scheme and bugfix for 32bit python#6144
kai ru (kairu-ms) merged 21 commits into
Azure:mainfrom
SethHollandsworth:main

Conversation

@SethHollandsworth

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Seth Hollandsworth (@SethHollandsworth),
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan

Copy link
Copy Markdown
Collaborator

confcom

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to still be a bit of confusion here about SVN vs version. Might be good to clarify variables names etc. to make it clearer.

Comment thread src/confcom/samples/sample-policy-output.rego Outdated
Comment thread src/confcom/azext_confcom/config.py Outdated
Comment thread src/confcom/.gitignore Outdated
Comment thread src/confcom/setup.py Outdated
Feature/sha256 hash, removing --json flag
adding warnings for save to file and debug mode.
making it so you can disable allow_elevated via the privileged field …
* securityContext

---------

Co-authored-by: Seth Hollandsworth <seth.hollandsworth@gmail.com>
Co-authored-by: Seth Hollandsworth <sethho@microsoft.com>
…privileges

changing default value of no_new_privileges
@SethHollandsworth
Seth Hollandsworth (SethHollandsworth) marked this pull request as ready for review May 1, 2023 18:13
@SethHollandsworth
Seth Hollandsworth (SethHollandsworth) marked this pull request as draft May 3, 2023 19:57
@yonzhan Yong Zhang (yonzhan) removed this from the April 2023 (2023-04-25) milestone May 4, 2023
@SethHollandsworth
Seth Hollandsworth (SethHollandsworth) marked this pull request as ready for review May 4, 2023 19:35
Comment thread src/confcom/azext_confcom/custom.py
Comment thread src/confcom/azext_confcom/rootfs_proxy.py
Comment thread src/confcom/setup.py
@kairu-ms
kai ru (kairu-ms) merged commit ead702f into Azure:main May 8, 2023
@azclibot

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=53328&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants