Add option for aks node restriction - #5247
Merged
Merged
Conversation
lht6
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
August 17, 2022 20:05
ghost
requested review from
ZelinWang (wangzelin007) and
Xing Zhou (zhoxing-ms)
August 17, 2022 20:05
ghost
assigned
ghost
requested a review
from Yong Zhang (yonzhan)
August 17, 2022 20:05
Collaborator
|
aks |
FumingZhang
reviewed
Aug 18, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
The PR looks good to me, could you please add a live test case for it?
| ++++++ | ||
|
|
||
| * Add --enable-node-restriction | ||
| * Update to use 2022-06-02-preview api version. |
Member
There was a problem hiding this comment.
Please also move the items under the Pending section to this release.
FumingZhang
reviewed
Aug 24, 2022
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') | ||
| def test_aks_create_and_update_with_node_restriction(self, resource_group, resource_group_location): |
ZelinWang (wangzelin007)
approved these changes
Aug 30, 2022
Xing Zhou (zhoxing-ms)
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-node-restriction
az aks update --enable-node-restriction
az aks update --disable-node-restriction
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.