Revert unnecessary version upgrade for aks_extension - #3612
Merged
Xing Zhou (zhoxing-ms) merged 1 commit intoJul 9, 2021
Conversation
Xing Zhou (zhoxing-ms)
force-pushed
the
revert_k8s_extention_0.5.2
branch
from
July 9, 2021 05:21
1c3076d to
254819b
Compare
Xing Zhou (zhoxing-ms)
requested review from
Zunli Hu (Juliehzl) and
Yu Chen (jsntcy)
July 9, 2021 05:36
Collaborator
|
Revert unnecessary version upgrade |
Yu Chen (jsntcy)
approved these changes
Jul 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modification #3605 has been added in this PR #3610
Therefore, there is no need to upgrade the version to
0.5.2(release pipeline failed before, so this package version has not been released yet)So revert this PR #3608
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.