[AKS] Add ossku parameter for cluster and nodepool creation - #3375
Merged
Jun Sun (JunSun17) merged 4 commits intoMay 20, 2021
Conversation
Henry Beberman (hbeberman)
requested review from
Ganesha (gtracer) and
Qingqing (zqingqing1)
as code owners
May 13, 2021 19:35
Henry Beberman (hbeberman)
requested a review
from Liming Liu (andyliuliming)
as a code owner
May 14, 2021 02:04
Henry Beberman (hbeberman)
force-pushed
the
azcli_add_ossku_parameter
branch
2 times, most recently
from
May 17, 2021 18:51
2def1c9 to
1f528de
Compare
Tony Xu (xuto2)
approved these changes
May 17, 2021
Jun Sun (JunSun17)
approved these changes
May 18, 2021
Jun Sun (JunSun17)
left a comment
Jun Sun (JunSun17)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Collaborator
|
AKS |
Yong Zhang (yonzhan)
requested review from
Zunli Hu (Juliehzl) and
Xing Zhou (zhoxing-ms)
May 18, 2021 23:48
Henry Beberman (hbeberman)
force-pushed
the
azcli_add_ossku_parameter
branch
from
May 20, 2021 16:48
1f528de to
2e26565
Compare
Tony Xu (xuto2)
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the new ossku parameter to cluster and nodepool creation. This OSSKU is used to select the OS image (Ubuntu or CBLMariner) for container host VM.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.