Skip to content

Creating CLI extension for Azure Quantum - #1879

Merged
Feiyue Yu (qwordy) merged 76 commits into
Azure:masterfrom
anpaz:master
Feb 1, 2021
Merged

Creating CLI extension for Azure Quantum#1879
Feiyue Yu (qwordy) merged 76 commits into
Azure:masterfrom
anpaz:master

Conversation

@anpaz

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci

Copy link
Copy Markdown

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/anpaz-msft/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

Comment thread src/quantum/HISTORY.rst Outdated
Comment thread src/quantum/README.rst
Comment thread src/quantum/azext_quantum/_client_factory.py Outdated
Comment thread src/quantum/azext_quantum/_client_factory.py
Comment thread src/quantum/azext_quantum/_help.py
Comment thread src/quantum/azext_quantum/_validators.py
Comment thread .github/CODEOWNERS Outdated
Comment thread src/quantum/azext_quantum/_params.py Outdated
Comment thread src/quantum/azext_quantum/_validators.py
Comment thread src/quantum/azext_quantum/_validators.py
Comment thread src/quantum/azext_quantum/_validators.py Outdated
Comment thread src/quantum/azext_quantum/commands.py
Comment thread src/quantum/azext_quantum/operations/workspace.py
Comment thread src/quantum/azext_quantum/profiles.py
Comment thread src/quantum/setup.cfg
Comment thread src/quantum/setup.py Outdated
Comment thread src/quantum/setup.py Outdated
Comment thread src/quantum/azext_quantum/commands.py Outdated
@qwordy

Feiyue Yu (qwordy) commented Jun 17, 2020

Copy link
Copy Markdown
Member

Please use same tense in help.

az quantum -h

Group
    az quantum : Manage Azure Quantum Workspaces and submit jobs to Azure Quantum Providers.
        This command group is in preview. It may be changed/removed in a future release.
Subgroups:
    job       : Manage jobs for Azure Quantum.
    target    : Manage execution targets for Azure Quantum workspaces.
    workspace : Manage Azure Quantum workspaces.

Commands:
    execute   : Submits a job for quantum execution on Azure Quantum, and waits for the result.

Comment thread src/quantum/README.rst Outdated
Comment thread src/quantum/README.rst Outdated
Comment thread src/quantum/README.rst Outdated
@qwordy

Copy link
Copy Markdown
Member

Are you still working on this PR?

@yungezz

Copy link
Copy Markdown
Member

hi @anpaz-msft are you still on this PR? If yes, could you pls look at comments and fix CI failure? Feel free to ping us if any question.

@yungezz

Copy link
Copy Markdown
Member

ping @anpaz-msft again for update

@yungezz Yunge Zhu (yungezz) removed this from the S171 milestone Aug 5, 2020
@anpaz

Copy link
Copy Markdown
Contributor Author

Based on feedback I received offline, I was requested to hold this until Azure Quantum service in in public preview; currently we are on Private Preview.

@qwordy

Copy link
Copy Markdown
Member

Andres Paz (@anpaz) Ricardo Espinoza (@ricardo-espinoza) Thank you for your work on this PR! It is really a large PR. I will merge it now. I created a issue #2956. We can discuss and resolve them in later releases.

@qwordy
Feiyue Yu (qwordy) merged commit 12f5b10 into Azure:master Feb 1, 2021
def _show_tip(msg):
import colorama
colorama.init()
print(f"\033[1m{colorama.Fore.YELLOW}{msg}{colorama.Style.RESET_ALL}")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we output warnings to stderr. Is there any reason to allow them to be sent to stdout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.