NetworkCloud CLI update v5.1.0 to add access bridge resource commands. - #10185
Conversation
… the API is made public.
|
Hi @idanielsteven, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates the networkcloud extension to v5.0.1 by introducing a new az networkcloud accessbridge command group (CRUD + wait), along with scenario tests/recordings, and aligning delete confirmations with --yes behavior.
Changes:
- Added generated AAZ command group and operations for
networkcloud accessbridge(create,update,show,list,delete,wait). - Added AccessBridge scenario test, recording, and test config entries.
- Added a confirmation prompt for
networkcloud virtualmachine console deleteand updated the test to pass--yes.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/networkcloud/HISTORY.rst | Release notes updated for v5.0.1 (includes AccessBridge addition). |
| src/networkcloud/azext_networkcloud/tests/latest/test_virtualmachineconsole.py | Updates VM console delete test to include --yes. |
| src/networkcloud/azext_networkcloud/tests/latest/test_accessbridge.py | New scenario test covering AccessBridge CRUD + wait + list flows. |
| src/networkcloud/azext_networkcloud/tests/latest/recordings/test_accessbridge_scenario1.yaml | New test recording for AccessBridge scenario. |
| src/networkcloud/azext_networkcloud/tests/latest/config.ini | Adds [ACCESS_BRIDGE] test configuration values. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/console/_delete.py | Adds confirmation prompt for VM console delete command. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/__cmd_group.py | Registers the networkcloud accessbridge command group. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/init.py | Exposes AccessBridge commands from the package. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_create.py | Generated create command for AccessBridge. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_delete.py | Generated delete command for AccessBridge (with confirmation). |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_list.py | Generated list command for AccessBridge (subscription / RG scope). |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_show.py | Generated show command for AccessBridge. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_update.py | Generated update command for AccessBridge. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_wait.py | Generated wait command for AccessBridge. |
Suppressed comments (2)
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_create.py:142
- Grammar typo in help text: "For as single address" should be "For a single address".
help="The set of IPv6 addresses permitted as the source or destination of the security rule. For as single address, utilize a /128 (CIDR notation). One or both Ipv4Addresses and Ipv6Addresses must be specified. Example formats: 2001:db8:abcd::1-2001:db8:abcd::ff or 2001:db8:abcd::1/64.",
src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/accessbridge/_update.py:108
- Grammar typo in help text: "For as single address" should be "For a single address".
help="The set of IPv6 addresses permitted as the source or destination of the security rule. For as single address, utilize a /128 (CIDR notation). One or both Ipv4Addresses and Ipv6Addresses must be specified. Example formats: 2001:db8:abcd::1-2001:db8:abcd::ff or 2001:db8:abcd::1/64.",
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
NetworkCloud |
|
[Release] Update index.json for extension [ networkcloud-5.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=175569362&view=results |
🤖 PR Validation —⚠️ Review suggested
NetworkCloud CLI update v5.1.0 to add access bridge resource commands.
aaz: Azure/aaz#1059
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.