Deploy contracts without EOAs involved by spalladino · Pull Request #811 · AztecProtocol/aztec-packages

spalladino · 2023-06-12T18:12:47Z

Removes the need for an EOA address to deploy a contract. However, since the deployer public key is now part of the deployment address (so we can reconstruct it during signature validation instead of hardcoding it, see #662), we do need to include it. We are passing it now as part of the ContractDeploymentData struct.

Also, since deployments no longer need to be authenticated, the API in the rpc-server for creating a tx is further simplified. We now just have a createTx and createDeployTx methods, without the separation betwen creating the request and the tx itself.

Fixes #661

ludamad · 2023-06-13T15:25:25Z


    boolean operator==(ContractDeploymentData<NCT> const& other) const
    {
-        return constructor_vk_hash == other.constructor_vk_hash && function_tree_root == other.function_tree_root &&


Might want to include msgpack_derived_equals.hpp and replace this with return utils::msgpack_derived_equals<boolean(*this, other) while you're here

ludamad · 2023-06-13T15:25:42Z


 template <typename NCT> std::ostream& operator<<(std::ostream& os, ContractDeploymentData<NCT> const& data)
 {
-    return os << "constructor_vk_hash: " << data.constructor_vk_hash << "\n"


Same this could be a msgpack derived output

ludamad · 2023-06-13T15:26:09Z

    using serialize::read;

+    read(it, data.deployer_public_key);
    read(it, data.constructor_vk_hash);


... TBH I wonder if a practical measure for now is to also derive this from msgpack (thinking aloud, not a review comment). It would give some wins before moving fully over (which is a bit hard to do with being assigned other priority tasks)

ludamad

Mechanics look good to me, but a sanity review on the actual issue at hand would be good

@iAmMichaelConnor

…on (#25520) ## Independent of the v6 upgrade PR (#25496) This PR is **not** a dependency of, and does not depend on, the v6 upgrade PR #25496. Either can merge first, and neither needs a rebase on the other. - **No shared source.** `DeployRollupForUpgradeV6.s.sol`, `V6UpgradeSimulation.sol` and `V6UpgradePayload.sol` import only `src/` contracts, the generated `HonkVerifier`, and each other. None of them imports `DeployRollupLib`, `RollupConfiguration`, `DeployRollupForUpgrade` or `DeployAztecL1Contracts`, which are the only Solidity files this PR changes. The V6 script's one mention of `RollupConfiguration` is a comment about version derivation, and this PR does not touch that function. - **No shared tooling.** The V6 runbook runs `forge script` on the V6 files directly. It does not use `run_rollup_upgrade.sh`, `test_rollup_upgrade.sh` or `stress_test_deploy.sh`, which are the shell scripts this PR edits. - **No contract change.** Nothing under `src/` changes, so the bytecode v6 deploys is identical with or without this PR. ## Problem `l1-contracts/script/deploy/` is the env-driven deployer for tests, spartan/CLI and testnets (mainnet versions use the pinned `DeployRollupForUpgradeV<N>.s.sol` scripts, which hard-code and verify their configuration). The generic path forwarded whatever the environment supplied straight into the `Rollup` constructor, and the constructor accepts values that leave the deployed instance unusable or mis-bound. Several defaults were also fail-open: a missing `REAL_VERIFIER` bound a `MockVerifier`, and a missing genesis root silently became zero. ## Change All in the deployer, its wrappers and its tests. `script/deploy/RollupConfiguration.sol` - `REAL_VERIFIER` defaults to `true`; a stub verifier must be requested explicitly. - `VK_TREE_ROOT`, `PROTOCOL_CONTRACTS_HASH` and `GENESIS_ARCHIVE_ROOT` must be set and non-zero. - `NETWORK=mainnet` requires chain id 1 and chain id 1 requires `NETWORK=mainnet`. `script/deploy/DeployRollupLib.sol` — `validateRollupConfig`, run before `new Rollup`: - slot, epoch and Ethereum slot durations non-zero; `slot × epoch` fits `uint32` (`TimeLib` multiplies without widening); - `exitDelaySeconds` non-zero; - `lagInEpochsForRandao ≥ 1`, validator-set lag not below it, and lag in seconds fits `uint32`; - each slash amount fits `uint96` (`SlashingProposer` encodes payload amounts as `uint96`); - `rewardDistributor` non-zero; `stakingAsset == GSE.ASSET()`. Two values are deliberately not rejected because the node's test paths rely on them: a zero `targetCommitteeSize` (`ValidatorSelectionLib` treats it as "no committee"; the local network and e2e fixtures use it) and an epoch longer than `MAX_CHECKPOINTS_PER_EPOCH` (e2e suites use 64 and 1000 to keep a run inside epoch 0). `script/deploy/DeployRollupForUpgrade.s.sol` — `REGISTRY_ADDRESS` must have code on the target chain. `scripts/run_rollup_upgrade.sh` no longer needs to override `REAL_VERIFIER`. `scripts/test_rollup_upgrade.sh` and `scripts/stress_test_deploy.sh` export the three genesis roots, and the two script tests set them in `setUp`. The node's TypeScript deployer already passes `REAL_VERIFIER` and all three genesis roots explicitly, and no in-tree, e2e or spartan configuration uses a value these checks reject. ## Tests New `test/script/DeployConfigValidation.t.sol` exercises each check on values via small harnesses rather than through `vm.setEnv`, because forge runs tests in parallel and the process environment is shared; its `setUp` sets the same env values as the other script tests for the same reason. Locally: ``` forge test --match-path 'test/script/*' Ran 3 test suites: 22 tests passed, 0 failed ``` `forge fmt --check` and `forge lint` are clean on the changed files apart from the pre-existing `unsafe-cheatcode` notes for `vm.setEnv`. CI covers the rest of the `l1-contracts` suite and the e2e suite. Not in this PR: wiring an `EscapeHatch` into the generic upgrade script, which needs a configuration surface for the hatch parameters rather than a guard. Closes AztecProtocol/aztec-claude#840 Closes AztecProtocol/aztec-claude#845 Closes AztecProtocol/aztec-claude#1371 Closes AztecProtocol/aztec-claude#688 Closes AztecProtocol/aztec-claude#684 Closes AztecProtocol/aztec-claude#707 Closes AztecProtocol/aztec-claude#865 Closes AztecProtocol/aztec-claude#657 Closes AztecProtocol/aztec-claude#689 Closes AztecProtocol/aztec-claude#1003 Closes AztecProtocol/aztec-claude#1355 Refs AztecProtocol/aztec-claude#686 Refs AztecProtocol/aztec-claude#811 Refs AztecProtocol/aztec-claude#1145 The eight constructor-input findings are closed at the deployer layer on purpose: the constructors in `src/` are unchanged because the mainnet pinned scripts assert these values themselves. If contract-level guards are wanted as well, change those lines to `Refs` before merging. #686 (zero committee) and #811 (epoch above the proof cap) are not closed here: both values are used by the node's own test paths, so any guard for them has to live in the pinned mainnet scripts, which already assert them. --- *Created by [claudebox](https://claudebox.work/v2/sessions/c27ea1045602719d/jobs/43) · group: `slackbot` · requested by Mike (@iAmMichaelConnor) · [Slack thread](https://aztecfoundation.slack.com/archives/D0B2N7W1WJD/p1789737469555569?thread_ts=1789737469.555569&cid=D0B2N7W1WJD)*

spalladino marked this pull request as ready for review June 13, 2023 01:10

spalladino requested review from LeilaWang and PhilWindle June 13, 2023 01:10

spalladino mentioned this pull request Jun 13, 2023

Unhardcode public key in account contract and inject it into the entrypoint #662

Closed

spalladino force-pushed the palla/deploy-no-eoa branch from 374aee9 to 0316b80 Compare June 13, 2023 11:55

spalladino enabled auto-merge (squash) June 13, 2023 11:56

spalladino added 8 commits June 13, 2023 09:57

Deploy contracts without EOAs involved

92469e8

Fixes

644f0fe

More fixes

037d4c9

Remove logs

67c2c96

Change issue linked in TODO

fc8561f

More fixes

d266c4b

Set deployment tx sender to zero

b75c448

And more fixes

913f442

spalladino force-pushed the palla/deploy-no-eoa branch from 0316b80 to 913f442 Compare June 13, 2023 12:57

ludamad reviewed Jun 13, 2023

View reviewed changes

ludamad approved these changes Jun 13, 2023

View reviewed changes

spalladino merged commit 3d9c230 into master Jun 13, 2023

spalladino deleted the palla/deploy-no-eoa branch June 13, 2023 15:27

AztecBot mentioned this pull request Sep 21, 2026

fix(l1): make the generic deployer refuse unusable rollup configuration #25520

Merged

Navigation Menu

Repository navigation

Deploy contracts without EOAs involved - #811

Deploy contracts without EOAs involved#811
spalladino merged 8 commits into
masterfrom
palla/deploy-no-eoa

spalladino commented Jun 12, 2023 •

edited

Loading

Uh oh!

ludamad Jun 13, 2023

Uh oh!

ludamad Jun 13, 2023

Uh oh!

ludamad Jun 13, 2023 •

edited

Loading

Uh oh!

ludamad left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

spalladino commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ludamad Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

ludamad Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

ludamad Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ludamad left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

spalladino commented Jun 12, 2023 •

edited

Loading

ludamad Jun 13, 2023 •

edited

Loading