Repository navigation
ci: add spa-build-in-place (build the SPA in test/e2e, no artifact hand-off) - #77
Merged
Merged
Conversation
…tifact The Actions artifact storage quota makes the frontend job's spa-dist upload fail on every PR, which turns ci / frontend red and stops the CI-Bot from merging. With spa-build-in-place: true the frontend job still runs typecheck, tests and the build but uploads nothing; the test and e2e jobs build the SPA themselves instead of downloading it. Default false, so no consumer changes until it opts in. Same pattern as release-pypi.yml's spa-build-in-publish (#76). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlinputspa-build-in-place(boolean, defaultfalse).frontendjob still runsnpm ci, typecheck,npm testandnpm run build, but skips thespa-dist-*upload. Thetestande2ejobs set up Node (unless e2e already does viae2e-has-node) and runnpm ci && npm run buildinfrontend/instead of downloading the artifact.ci.ymllists the input.Why
CognitiveSystems has hit the Free-plan Actions artifact storage quota (resets Dec 1). Every PR's
ci / frontendfails atupload-artifact, so the CI-Bot never merges. Same pattern asrelease-pypi.yml'sspa-build-in-publish(#76). Default off: no consumer behaviour changes until one opts in.Test plan
v1advance (human-confirmed): a CognitiveSystems PR withspa-build-in-place: trueshowsci / frontend,ci / testandci / e2egreen.🤖 Generated with Claude Code