Skip to content

ci: add spa-build-in-place (build the SPA in test/e2e, no artifact hand-off) - #77

Merged
ghostkernel-core merged 1 commit into
masterfrom
spa-build-in-place
Nov 11, 2026
Merged

ghostkernel-core merged 1 commit into
masterfrom
spa-build-in-place

Conversation

@ghostkernel-core

Copy link
Copy Markdown
Contributor

Summary

  • New ci.yml input spa-build-in-place (boolean, default false).
  • When true: the frontend job still runs npm ci, typecheck, npm test and npm run build, but skips the spa-dist-* upload. The test and e2e jobs set up Node (unless e2e already does via e2e-has-node) and run npm ci && npm run build in frontend/ instead of downloading the artifact.
  • README row for ci.yml lists the input.

Why

CognitiveSystems has hit the Free-plan Actions artifact storage quota (resets Dec 1). Every PR's ci / frontend fails at upload-artifact, so the CI-Bot never merges. Same pattern as release-pypi.yml's spa-build-in-publish (#76). Default off: no consumer behaviour changes until one opts in.

Test plan

  • YAML parses; diff limited to the gated steps.
  • After merge + v1 advance (human-confirmed): a CognitiveSystems PR with spa-build-in-place: true shows ci / frontend, ci / test and ci / e2e green.

🤖 Generated with Claude Code

…tifact

The Actions artifact storage quota makes the frontend job's spa-dist upload fail on
every PR, which turns ci / frontend red and stops the CI-Bot from merging. With
spa-build-in-place: true the frontend job still runs typecheck, tests and the build
but uploads nothing; the test and e2e jobs build the SPA themselves instead of
downloading it. Default false, so no consumer changes until it opts in.
Same pattern as release-pypi.yml's spa-build-in-publish (#76).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ghostkernel-core
ghostkernel-core requested a review from a team as a code owner November 11, 2026 19:43
@ghostkernel-core
ghostkernel-core merged commit fb94f7b into master Nov 11, 2026
17 checks passed
@ghostkernel-core
ghostkernel-core deleted the spa-build-in-place branch November 11, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant