Fakeplayers incorrectly invalid with . and + #42

Activity

1. Arcensoth

   self-assigned this

   on Nov 11, 2020
2. Arcensoth

   added

   bugSomething isn't workingSomething isn't working

   on Nov 11, 2020
3. Arcensoth commented on Nov 13, 2020

   

   Arcensoth

   on Nov 13, 2020

   Last edited by Arcensoth

   Owner

   More actions

   It looks like this token is being categorized as an NBT path. This is a recursive structure (with braces, etc) so it's not feasible to try and back-track after it see an invalid character at the very end.

   The underlying issue is that fakeplayers are sometimes impossible to distinguish between other types of tokens. It's worth noting that the grammar does indeed check for a fakeplayer before an NBT path.

   language-mcfunction/lib/src/grammars/version-agnostic.yaml

   Lines 371 to 376 in 04eeeaa

   	- include: "#command.token.fakeplayer"
   	- include: "#command.token.nbt_path"
   	- include: "#command.token.quoted_string"
   	- include: "#command.token.single_quoted_string"
   	- include: "#command.token.unquoted_string"
   	- include: "#command.token.unknown"

   However, to avoid ambiguity, the version-agnostic grammar specifically requires one of the symbols #$% before it assumes something is a fakeplayer:

   language-mcfunction/lib/src/grammars/version-agnostic.yaml

   Lines 119 to 121 in 04eeeaa

   	# various popular fakeplayer formats
   	# they'd get classified as unquoted strings anyway
   	fakeplayer: '([\#\$\%]{{unquoted_string_nc}})'

   So you should be able to tell the highlighter directly by appending, say, $ to the front of your fakeplayers, if it suits you.

   I'd say it's at least reasonable to expect an error to not be highlighted here, such as with an unquoted string. Not sure how to fix that quite yet though, since unquoted strings are a superset of NBT paths and must be processed afterwards.
4. rx-dev commented on Nov 13, 2020

   

   rx-dev

   on Nov 13, 2020

   Author

   More actions

   I think that's reasonable, a bit unfortunate ofc. I always use $'s except for load stuff so I don't mind having the blotch of red here.