Replace the ES5-era claims in the README - #133
Merged
FlorianRappl merged 1 commit intoJul 30, 2026
Merged
Conversation
Jint has implemented ES2015 through ES2025 for several releases now, so describing it as "fully ECMAScript 5 compatible" understates what scripts this binding can actually run. The features list gains the module, import map and Web Worker support that has since landed, and names the library fixtures the test suite exercises. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lahma
marked this pull request as ready for review
July 30, 2026 08:04
FlorianRappl
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README still says Jint "is fully ECMAScript 5 compatible" and lists "Support of ES5 through Jint" as the headline feature. Jint has implemented ES2015 through ES2025 for several releases (we are on 4.15.3), so the README understates what scripts this binding can actually run — a reader evaluating AngleSharp.Js for a page built with classes, modules or
async/awaitwould conclude it cannot handle them.What changed
type="module"andtype="importmap"scripts are evaluated, whichJsScriptingService.SupportsTypehas accepted for a while but the README never said.Verification
I did not want to copy Jint's feature list on faith, so I ran the claims through this binding layer as script — private class fields,
async/await, generators, optional chaining with??, spread of aSet, template literals,Proxy/Reflect/BigInt/Symbol,Object.groupBy(ES2024) andSet.prototype.union(ES2025) all evaluate correctly throughEvalScriptAsync, as does destructuring a spreadquerySelectorAllresult. Those probes were scratch tests and are not part of the diff.Documentation only — no
CHANGELOG.mdentry, since nothing in the package changed.docs/carries no comparable stale claim; the only ES5 references in the repository were the two in the README.🤖 Generated with Claude Code