Skip to content

[PWGEM,PWGHF] Clean up code-check errors and warnings - #17285

Open
mhemmer-cern wants to merge 3 commits into
AliceO2Group:masterfrom
mhemmer-cern:clean-up
Open

[PWGEM,PWGHF] Clean up code-check errors and warnings#17285
mhemmer-cern wants to merge 3 commits into
AliceO2Group:masterfrom
mhemmer-cern:clean-up

Conversation

@mhemmer-cern

Copy link
Copy Markdown
Collaborator

Clean up some code-check errors and warnings in the PWGEM/PhotonMeson/Utils part. Resulting changes affected also one code in HF so I touched that one file and fixed the things there too. I hope that's okay.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 181 errors, ⚠️ 300 warnings, 🔕 16 disabled

@mhemmer-cern
mhemmer-cern enabled auto-merge (squash) August 1, 2026 20:48
@mhemmer-cern
mhemmer-cern disabled auto-merge August 1, 2026 20:49
@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6af663d at 2026-08-01 23:35:

## sw/BUILD/O2Physics-latest/log
2026-08-01T23:00:51.202+0200 [47314:140211191344768] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: Socket closed]
2026-08-01T23:00:51.246+0200 [47314:140211191344768] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:52.343+0200 [46974:140401585938048] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:53.593+0200 [47750:140547804020352] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:54.959+0200 [46906:140079223828096] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:55.521+0200 [47749:140277299089024] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:55.825+0200 [47558:140564925197952] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:01.762+0200 [47594:139755354320512] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:07.683+0200 [47536:140677053124224] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:09.252+0200 [48817:139864223784576] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:53.047+0200 [49060:140479311867520] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:53.047+0200 [49060:140479311867520] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:54.105+0200 [49094:140271596740224] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:54.105+0200 [49094:140271596740224] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:57.111+0200 [49181:140228879289984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:57.111+0200 [49181:140228879289984] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:56.479+0200 [49148:140222273638016] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:56.479+0200 [49148:140222273638016] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:58.736+0200 [49255:139903785102976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:58.736+0200 [49255:139903785102976] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:01:04.984+0200 [49332:140025258942080] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:04.984+0200 [49332:140025258942080] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:57.404+0200 [49206:139695373041280] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:57.404+0200 [49206:139695373041280] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:00:59.682+0200 [49284:139834919038592] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:00:59.682+0200 [49284:139834919038592] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:01:10.846+0200 [49373:139964414926464] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:10.846+0200 [49373:139964414926464] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused
2026-08-01T23:01:11.725+0200 [49399:139786821205632] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-08-01T23:01:11.726+0200 [49399:139786821205632] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 43 errors and 0 warnings.'
Found 43 errors and 0 warnings.
++ [[ 43 -gt 0 ]]
++ cat /sw/BUILD/d4d6e818d7011aa94d5c5e49bc26a078f1287a2b/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:19:10: error: 'PWGEM/PhotonMeson/Core/EMCPhotonCut.h' file not found [clang-diagnostic-error]
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:27:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:29:1: error: included header array is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/ClusterHistograms.h:31:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/EventHistograms.h:19:10: error: 'Common/CCDB/EventSelectionParams.h' file not found [clang-diagnostic-error]
PWGEM/PhotonMeson/Utils/EventHistograms.h:29:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/HNMUtilities.h:20:10: error: 'PWGEM/PhotonMeson/DataModel/gammaTables.h' file not found [clang-diagnostic-error]
PWGEM/PhotonMeson/Utils/HNMUtilities.h:36:1: error: included header vector is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Utils/HNMUtilities.h:103:11: error: variable 'massHNM' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

2 participants