Skip to content

[PWGLF] Add vs Y and Eta predictions, cleanup task - #17284

Merged
njacazio merged 1 commit into
masterfrom
njacazio-patch-4
Aug 1, 2026
Merged

[PWGLF] Add vs Y and Eta predictions, cleanup task#17284
njacazio merged 1 commit into
masterfrom
njacazio-patch-4

Conversation

@njacazio

@njacazio njacazio commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Added new histograms for Y and Eta distributions, and updated the configuration structure for binning and predictions. Improved particle selection criteria and added new configurable parameters for cuts.

Added new histograms for Y and Eta distributions, and updated the configuration structure for binning and predictions. Improved particle selection criteria and added new configurable parameters for cuts.
@github-actions github-actions Bot added the pwglf label Aug 1, 2026
@github-actions github-actions Bot changed the title Add vs Y and Eta predictions, cleanup task [PWGLF] Add vs Y and Eta predictions, cleanup task Aug 1, 2026
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 5 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 80ff7e2 at 2026-08-01 20:14:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 33 errors and 0 warnings.'
Found 33 errors and 0 warnings.
++ [[ 33 -gt 0 ]]
++ cat /sw/BUILD/7be56fb758b97e6112f2139f568393d6d30bc554/O2Physics-code-check/errors.txt
PWGLF/Tasks/QC/mcParticlePrediction.cxx:60:14: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:61:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:61:6: error: variable 'enabledParticlesArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:88:26: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:120:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:120:6: error: variable 'enabledEstimatorsArray' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:121:14: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:143:59: error: variable 'hestimators' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:144:59: error: variable 'hestimatorsVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:145:59: error: variable 'hestimatorsVsETA05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:146:59: error: variable 'hestimatorsVsETA08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:147:59: error: variable 'hestimatorsVsImpactParameter' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:148:59: error: variable 'hestimatorsRecoEvGenVsReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:149:59: error: variable 'hestimatorsRecoEvGenVsReco_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:150:59: error: variable 'hestimatorsRecoEvGenVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:151:59: error: variable 'hestimatorsRecoEvRecoVsITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:152:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:153:59: error: variable 'hestimatorsRecoEvRecoVsRecoITS_BCMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:154:59: error: variable 'hestimatorsRecoEvRecoVsFT0A' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:155:59: error: variable 'hestimatorsRecoEvRecoVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:156:59: error: variable 'hestimatorsRecoEvVsBCId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:157:59: error: variable 'hvertexPosZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:158:93: error: variable 'hpt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:159:93: error: variable 'hy' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:160:93: error: variable 'heta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:161:93: error: variable 'hyield' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:163:8: error: constructor does not initialize these fields: pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:193:51: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:196:54: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:436:5: error: uninitialized record type: 'nMult' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:731:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/QC/mcParticlePrediction.cxx:743:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Utils/inelGt.h:117:11: error: using integer absolute value function 'abs' when argument is of floating point type [clang-diagnostic-absolute-value,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 33 -gt 0 ]]
++ exit 1
--

Full log here.

@njacazio
njacazio merged commit e40292b into master Aug 1, 2026
12 of 14 checks passed
@njacazio
njacazio deleted the njacazio-patch-4 branch August 1, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants