Skip to content

[PWGLF] Added cosTheta* and phi definition in generated and reconstructed MC - #17283

Open
sawankumawat wants to merge 2 commits into
AliceO2Group:masterfrom
sawankumawat:master
Open

[PWGLF] Added cosTheta* and phi definition in generated and reconstructed MC#17283
sawankumawat wants to merge 2 commits into
AliceO2Group:masterfrom
sawankumawat:master

Conversation

@sawankumawat

Copy link
Copy Markdown
Contributor
  • Added cosTheta* and phi definition in generated and reconstructed MC
  • Added function to give cosTheta* and phi value based on the chosen frame to simplify the code.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4aebcc4 at 2026-08-01 19:19:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 27 errors and 52 warnings.'
Found 27 errors and 52 warnings.
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/41be3499578d81f770f5428a10fdd4c8ffdf8228/O2Physics-code-check/errors.txt
PWGLF/Tasks/Resonances/higherMassResonances.cxx:79:8: error: constructor does not initialize these fields: theta2, detId, refAId, refBId, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:256:35: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:256:65: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:256:99: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:256:131: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:256:161: error: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:467:31: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:469:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:798:8: error: no header providing "std::pair" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1049:47: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1083:29: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1145:26: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1222:54: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1243:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1534:49: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1607:43: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1668:49: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1697:23: error: narrowing conversion from 'unwrap_t<float>' (aka 'float') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1768:47: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1814:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1815:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1816:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1817:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1904:47: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1953:47: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:1975:29: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:2002:26: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 52 -gt 0 ]]
++ cat /sw/BUILD/41be3499578d81f770f5428a10fdd4c8ffdf8228/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Resonances/higherMassResonances.cxx:489:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:492:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:494:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:499:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:502:96: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:504:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:507:98: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:509:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:514:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:517:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:519:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:527:18: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Resonances/higherMassResonances.cxx:530:64: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 4f66c51 at 2026-08-01 19:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:9: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:16: error: expected unqualified-id before '-=' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4f66c51 at 2026-08-01 19:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:9: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:16: error: expected unqualified-id before '-=' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 4f66c51 at 2026-08-02 04:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:9: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/higherMassResonances.cxx:216:16: error: expected unqualified-id before '-=' token
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants