Skip to content

[PWGLF] adding info for centrality cloures - #17267

Merged
romainschotter merged 6 commits into
AliceO2Group:masterfrom
lietava:omegahm
Aug 1, 2026
Merged

[PWGLF] adding info for centrality cloures#17267
romainschotter merged 6 commits into
AliceO2Group:masterfrom
lietava:omegahm

Conversation

@lietava

@lietava lietava commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 45 errors, ⚠️ 15 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title adding info for centrality cloures [PWGLF] adding info for centrality cloures Jul 30, 2026
@lietava
lietava marked this pull request as ready for review July 31, 2026 13:28
@romainschotter
romainschotter enabled auto-merge (squash) July 31, 2026 13:36
@alibuild

alibuild commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f3a954a at 2026-07-31 19:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 36 errors and 0 warnings.'
Found 36 errors and 0 warnings.
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/d1e512ef410bf8f47481fb7a2402292e6007ae9c/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:171:22: error: 'nParticles' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:172:22: error: 'nCutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:173:39: error: 'matterOrNot' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:174:39: error: 'particlesNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:175:39: error: 'cutsNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:176:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:176:24: error: 'cutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:183:30: error: variable 'gCandidates' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:184:30: error: variable 'gCandidatesNT' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:188:8: error: constructor does not initialize these fields: mCCDB, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:227:69: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:262:9: error: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:300:21: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:301:24: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:491:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:526:7: error: uninitialized record type: 'momenta' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:527:7: error: uninitialized record type: 'cascadeMomentum' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:637:71: error: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:649:19: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:855:11: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1021:13: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1030:13: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1041:13: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1049:13: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1068:11: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1079:11: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1094:12: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1105:11: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1115:11: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1135:13: error: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1149:22: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1157:23: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1159:23: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1205:22: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1213:23: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1215:23: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 36 -gt 0 ]]
++ exit 1
--

Full log here.

@romainschotter
romainschotter merged commit 9c8d91e into AliceO2Group:master Aug 1, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lietava @alibuild @romainschotter