Skip to content

Diamond Pipes only drop item in first filter slot when broken #45

Open

Description

@Kneelawk

While messing around with SimplePipes in a test world, I noticed that a diamond pipe, when broken, either in creative or survival, did not drop the items I had put into its filter inventory. I looked through the source a little to find what could be causing this and I noticed in TilePipeItemDiamond.removeItemsForDrop() only removed/returned the item in the pipe's first inventory slot. I tested this in a world and found that the pipe indeed did drop any item placed in the first inventory slot but not in any other slots.

This is likely a simple fix. I can probably create a pull-request fixing this if necessary.

Activity

  1. AlexIIL commented on Jul 13, 2020

    @AlexIIL
    Owner

    (I'll close this when I've actually tested and released the fix).

  2. Kneelawk commented on Jul 13, 2020

    @Kneelawk
    CollaboratorAuthor

    I just tested the fix. Diamond pipes seem to drop all the items in their filters now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions