Repository navigation
Key the statement cache on the SQL text instead of its hash - #2602
Merged
Merged
Conversation
mathiasrw
approved these changes
Oct 19, 2026
Member
|
Smooth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2587
alasql.dexeclooked updb.sqlCacheanddb.astCacheby a 32-bit hash of the SQL text and never compared the text on a hit, so two statements with the same hash shared one compiled statement. The key is now the text itself (plus thejoinstaroption as before), option B from the issue.Added
test/test2587.jswith the colliding pair from the issue (SELECT 369825 AS a/SELECT 1025164 AS a); it fails before the change.I ran the suite with mocha on Node instead of bun: the only difference before and after the change is the new test going from failing to passing. The remaining failures (Test 107-B, 1645, CLI) fail the same way on
developon my machine (Windows).