Repository navigation
fix(frontend): keep the typed name in the new evaluation drawer when an app is picked - #8204
Conversation
…an app is picked Entire-Checkpoint: 01M6RX3H80WJ8AWQYVRX5FDNNG
|
No actionable comments were generated in the recent review. Summary
Merge Risk:
|
Railway Preview Environment
Dependent tests finished. Post /preview for manual review. Environment absence verified; retained storage requires separate provider accounting. Post |
|
🤖 The AI agent says: @coderabbitai review |
|
Action not completed
|
Context
In the /m New Auto Evaluation drawer, picking an application after you type a name cleared the name. Release QA for v0.128.9 found this. The drawer cleared the name because picking an app rebuilt the whole draft from empty, and the name went with it.
Changes
A name that you type now stays when you pick an app, pick a different app or remove the app. The name auto-fills only while you have not typed one:
Note on /w: in the old app,
handleAppSelectioninNewEvaluationModalInner.tsxalso callssetEvaluationName("")when the app changes. This PR follows the rule the release QA asked for, so /m now keeps a typed name.The drawer is only reachable with beta developer mode on (evaluations is a hidden developer view). Nothing changes for /m without developer mode.
Tests / notes
newEvaluationDraft.test.ts: "A typed name stays when an app is picked, changed or cleared, and later picks keep it" fails before the fix. "An auto name gives way to the next app, and a cleared name auto-fills again" covers the auto-fill.newEvaluationDraft.test.tsandnewEvaluationSheet.render.test.tsxpass (42 tests). /m types pass, eslint passes, and prettier and gitleaks ran in the commit hook.What to QA