Repository navigation
Conversation
…on-web PRs The web unit job ran every package one after another for about 32 minutes, and it ran on API, SDK and dependency PRs that change no web code. - Detect web changes with dorny/paths-filter; skip the web shards otherwise. - Run mobile in 3 vitest shards, entity-ui alone, and the other packages together, each on its own runner. - Stop running the old /w app tests (web/oss vitest and Playwright unit specs), so the job no longer installs Chromium. - Keep one run-web-unit-tests check that publishes all results and fails when any shard fails. Entire-Checkpoint: 01M6R6E7GAXZ021VBPJVGYVE2V
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
🤖 The AI agent says: Measured on this PR's first run (run 42202999493). All 5 shards passed. The published check reports 9,100 tests passing.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run-web-unit-teststook about 32 minutes on every PR, and every PR waited for it.mobilealone took 13.6 minutes.uv.lockfiles and still ran 33 minutes of web tests.web/ossvitest, 3.5 minutes, plus 7 Playwright specs that needed a Chromium install).Measured from 108 finished runs since 2026-11-04. Before #8116 (all packages at once), 71 of 81 runs failed, mostly on timeouts. After #8116 (one package at a time), 4 of 27 runs failed: 3 were real bugs in the PR (#8130, #8133, #8116), and 1 looked flaky (#8134). So the job finds real bugs. The issue is the time.
Change
detect-web-changesjob checks the changed files withdorny/paths-filter. The web shards run only when something underweb/or this workflow changed.mobilein 3 vitest shards,entity-uialone, and the other packages together. Inside each job, packages still run one at a time, so the CPU starvation from before fix(frontend): web unit tests fail at random from CPU contention #8116 does not come back.web/ossandweb/eetests no longer run here, so the job no longer installs Chromium.run-web-unit-testsjob collects the JUnit files, publishes one "Application Web Unit Test Results" check, and fails when any shard fails. It passes when the shards were skipped because no web code changed. Agents and rules can keep waiting on the same check name.run-tests.tsis unchanged, so the local--layer unitcommand still runs everything.Before and after