Repository navigation
feat(frontend): App overview in /m behind the developer view switch - #8044
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Railway Preview Environment
Preview use finished or expired. Environment absence verified; retained storage requires separate provider accounting. Post |
added 3 commits
November 3, 2026 17:49
mmabrouk
force-pushed
the
feat/m-view-evaluations
branch
from
November 3, 2026 17:29
e902f37 to
417f855
Compare
mmabrouk
force-pushed
the
feat/m-view-app-overview
branch
from
November 3, 2026 17:29
3d49856 to
7eb1894
Compare
mmabrouk
changed the base branch from
feat/m-view-evaluations
to
release/v0.128.5
November 4, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge into v0.128.4. This goes into the next release.
Stacked on #8040 (the evaluation runs list). Merge #8040 first. The base of this PR is
feat/m-view-evaluations.Context
/m has an overview page for agents, but not for prompt and custom apps, so users still open the /w app overview for them. This PR adds that overview to /m at
/apps/{app_id}/overview, the same path as /w. It reuses the /m runs list table from #8040 for the evaluation sections.It ships hidden
Nothing here is reachable until the
app-overviewdeveloper view is enabled. The view has no navigation link, because its route has an app id in it. While the view is hidden, the route shows "page not found". The PR adds no dependency, no antd, and nothing in_app,AppProviders,GlobalDrawersor the app shell. The screen loads lazily from its route.What the overview does
variantsview is on, a card opens the Variants deployments tab for that environment.variantsview is on.evaluationsview is on.edit_workflows, so a viewer sees only "Copy Slug". Rename opens a dialog with name, description and read-only details. Archive asks to confirm, then goes to the project home.app-overviewview is on, and it does not prefetch.The Variants view files change a little so the overview can reuse them:
VariantsTabletakes optional fold and delete props, and the environment cards can be links. The Variants view looks and works as before.Not in this PR: the usage charts (Requests, Latency, Cost, Tokens), the Playground buttons, and "Configure" for custom workflows.
/w bugs fixed in /m
Each fix has a test.
Package changes
None.
New user-facing text
Strings not copied from /w: "App actions", "Archive app" (the menu item), "Couldn't rename this app", "Could not load deployments", and "Overview" (the link beside the app pickers).
Checks
Types:
@agenta/mobilepasses. No package changed, so /w types were not run.Lint: 0 errors.
Full mobile tests: 1091 passed, 2 failed. The two failures are
agentPermissions.render.test.tsxandmembersTabRoleChange.render.test.tsx. Both also fail on the release branch.The Rename and Archive tests use the real package save code and mock only HTTP. They assert the exact request payload.
speed:checkpasses. The new overview route has no budget yet (1209.4 KB first load).Storybook screenshots were taken for 6 states at 1440 and 390 px, light and dark (24 images). The capture reported no render errors and no horizontal overflow.
Not run: the overview against a live API.
After the rebase onto
release/v0.128.4(atd5bc67afec, with feat(frontend): evaluators and archived evaluators in /m behind the developer view switch #8007 and fix(frontend): pass the leave question to the shared unsaved guard in the test set editor #8031):@agenta/mobilepasses. This PR does not changeweb/packages.Review results
Two rounds with the slop, simplify and Codex correctness lenses. The final head (
da01701c72) has slop Low and simplify Low. Correctness is Medium for one open case (below). The round 1 fixes made theVariantsTableprops optional and refresh the app caches after a saved rename or archive, even when a later read or the navigation fails.Open problems
updateWorkflowreads the revision back after the rename is saved. If that read fails, /m shows "Couldn't rename this app" and keeps the dialog open, although the rename was saved. The fix belongs in@agenta/entitiesand needs a /w type check. It must land before the view goes to preview.on, the route needs amobileRouteForentry so the /w overview path opens /m.How to QA once enabled
Enable the views with
AGENTA_DEVELOPER_VIEWS=app-overview,variants,evaluations(the last two turn on the links). Then:/apps/{agent id}/overview. You land on the agent overview.app-overviewoff, there is no "Overview" button and the pages work as before.