Skip to content

Refactor: remove StyleProps type to eliminate code duplication - #1800

Closed
ashrafchowdury wants to merge 5 commits into
Agenta-AI:mainfrom
ashrafchowdury:refactor/style-props-type
Closed

ashrafchowdury wants to merge 5 commits into
Agenta-AI:mainfrom
ashrafchowdury:refactor/style-props-type

Conversation

@ashrafchowdury

Copy link
Copy Markdown
Contributor

Description:
Refactored the codebase by removing all the StyleProps types, which is currently leading to code duplication.

Changes:

  1. Declared a StyleProps type in the Types.ts file.
  2. Imported the StyleProps type wherever it is used.

@vercel

vercel Bot commented Jun 18, 2024

Copy link
Copy Markdown

@ashrafchowdury is attempting to deploy a commit to the mmabrouk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. frontend refactor A code change that neither fixes a bug nor adds a feature typescript labels Jun 18, 2024
@aakrem
aakrem requested a review from bekossy June 23, 2024 17:41

@bekossy bekossy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ashrafchowdury

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 24, 2024
@bekossy
bekossy requested review from aakrem and mmabrouk July 5, 2024 09:52
@vercel

vercel Bot commented Jul 5, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 3:14pm

This branch was successfully deployed

1 active deployment
Preview — 1bc60f9e Deployed Jul 5, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend lgtm This PR has been approved by a maintainer refactor A code change that neither fixes a bug nor adds a feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants