Skip to content

[codex] Fix AppCheck provider factory return type - #158

Merged
AdamEssenmacher merged 1 commit into
mainfrom
codex/fix-appcheck-provider-factory-return
Apr 15, 2026
Merged

AdamEssenmacher merged 1 commit into
mainfrom
codex/fix-appcheck-provider-factory-return

Conversation

@AdamEssenmacher

Copy link
Copy Markdown
Owner

Summary

  • Change FIRAppCheckProviderFactory.createProviderWithApp: to return IAppCheckProvider instead of NSObject.
  • Match the FirebaseAppCheck .xcframework header, which declares a nullable id<FIRAppCheckProvider> return.
  • Keep audit suppression changes out of this PR.

Validation

  • scripts/compare-firebase-bindings.sh --targets AppCheck --output-dir output/firebase-binding-audit-appcheck-fixed-20260415-032809
  • dotnet tool run dotnet-cake -- --target=nuget --names=Firebase.AppCheck

@AdamEssenmacher
AdamEssenmacher marked this pull request as ready for review April 15, 2026 17:51
@AdamEssenmacher
AdamEssenmacher merged commit c4203ed into main Apr 15, 2026
1 check passed
@AdamEssenmacher
AdamEssenmacher deleted the codex/fix-appcheck-provider-factory-return branch April 15, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant