Repository navigation
Conversation
|
|
A derivedFrom peripheral that declares no <registers> of its own is, by SVD semantics, just another instance of its base peripheral's layout. Read_Peripheral unconditionally overwrote Type_Name with the peripheral's own name, so it always got a distinct, duplicate record type, and Device.Dump bucketed peripherals only by groupName, so a groupless derivedFrom peripheral always got its own file too. Read_Peripheral now tracks whether a peripheral declares its own <registers> or <headerStructName>, and restores the base's Type_Name when neither is present. Device.Dump gains a second grouping pass: groupless peripherals that end up sharing a Type_Name are folded into one synthetic group (labeled by that Type_Name) and handed to the existing Group_Name-based Dump, which already emits one shared type when content matches and falls back to separate types otherwise. Peripherals with their own registers, their own headerStructName, or an explicit groupName are unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ThyMYthOS
force-pushed
the
peripheral-folding
branch
from
October 6, 2026 21:02
185048c to
daf7f34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A derivedFrom peripheral that declares no of its own is, by SVD semantics, just another instance of its base peripheral's layout. Read_Peripheral unconditionally overwrote Type_Name with the peripheral's own name, so it always got a distinct, duplicate record type, and Device.Dump bucketed peripherals only by groupName, so a groupless derivedFrom peripheral always got its own file too.
Read_Peripheral now tracks whether a peripheral declares its own or , and restores the base's Type_Name when neither is present. Device.Dump gains a second grouping pass: groupless peripherals that end up sharing a Type_Name are folded into one synthetic group (labeled by that Type_Name) and handed to the existing Group_Name-based Dump, which already emits one shared type when content matches and falls back to separate types otherwise.
Peripherals with their own registers, their own headerStructName, or an explicit groupName are unaffected.