Repository navigation
Conversation
Similar_Type decides two registers can share one generated Ada type by comparing field count, Dim, and field equality, but never compared Reg_Properties.Size. Equal, right above it, already does. Registers whose names share a stem after Common_Prefix strips trailing digits (e.g. FLUSH64/FLUSH32) could merge into one type despite different sizes, producing a register typed narrower or wider than its real width. Add the missing size check, matching Equal and placed next to the existing Dim check. Also fix "modifiedWriteValue" to "modifiedWriteValues", matching the actual CMSIS-SVD tag and descriptors-field.adb's spelling. The typo silently dropped every register-level <modifiedWriteValues> element into the catch-all branch instead of recording it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ThyMYthOS
force-pushed
the
size-mismatch
branch
from
October 6, 2026 21:01
9162402 to
314265e
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar_Typedecides two registers can share one generated Ada type by comparing field count, Dim, and field equality, but never comparedReg_Properties.Size.Equal, right above it, already does. Registers whose names share a stem afterCommon_Prefixstrips trailing digits (e.g. FLUSH64/FLUSH32) could merge into one type despite different sizes, producing a register typed narrower or wider than its real width. Add the missing size check, matchingEqualand placed next to the existing Dim check.Also fix "modifiedWriteValue" to "modifiedWriteValues", matching the actual CMSIS-SVD tag and descriptors-field.adb's spelling. The typo silently dropped every register-level
<modifiedWriteValues>element into the catch-all branch instead of recording it.