docs(canary-fleet): correct timeout PUT field name in manifest header - #915
Merged
Merged
Conversation
The post-deploy PUT body documented in config/canary-fleet.yaml used
`timeout_seconds`, but PUT /api/agents/{name}/timeout requires
`execution_timeout_seconds` (returns "execution_timeout_seconds is
required" otherwise). Caught while deploying the slow agent on dev.
vybe
approved these changes
May 23, 2026
vybe
left a comment
vybe
left a comment
Contributor
There was a problem hiding this comment.
Approved — 1-line doc-comment fix matches the actual endpoint contract in agent_config.py:502. All 12 CI checks green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/canary-fleet.yamldocumented the post-deploy timeout PUT body as{"timeout_seconds": 180}, but the API endpointPUT /api/agents/{name}/timeoutrequiresexecution_timeout_secondsand rejects the request withexecution_timeout_seconds is requiredotherwise.Caught during
Deploying the slow agent (
canary-fleet-slow) on the dev instance via the documented recipe.Test plan
PUTbody against dev —execution_timeout_seconds: 180returns{"message":"Timeout updated","execution_timeout_minutes":3}